Skip to content

Commit 2cde168

Browse files
aslushnikovCommit bot
authored and
Commit bot
committed
Revert of DevTools: Correct Source Panel Show/Hide Toolbar buttons (patchset #1 id:1 of https://codereview.chromium.org/2600493002/ )
Reason for revert: It turned out the icons are actually wrong. Compare: - Without this patch (correct): http://imgur.com/a/eFCnz - With this patch (incorrect): http://imgur.com/a/gJ24q Original issue's description: > DevTools: Correct Source Panel Show/Hide Toolbar buttons > > Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools. > > Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers. > > BUG=671930 > R=lushnikov@chromium.org > TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons > are correctly aligned. crbug.com/671930 > > Review-Url: https://codereview.chromium.org/2600493002 > Cr-Commit-Position: refs/heads/master@{#445339} > Committed: https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efccd843cb81aa8 TBR=dgozman@chromium.org,pfeldman@chromium.org,me@jakehendy.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671930 Review-Url: https://codereview.chromium.org/2655793003 Cr-Commit-Position: refs/heads/master@{#445983}
1 parent 53bf5fa commit 2cde168

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

front_end/ui/Icon.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,10 @@ UI.Icon.Descriptors = {
170170

171171
'largeicon-show-left-sidebar': {x: -160, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
172172
'largeicon-hide-left-sidebar': {x: -192, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
173-
'largeicon-show-right-sidebar': {x: -192, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
174-
'largeicon-hide-right-sidebar': {x: -160, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
173+
'largeicon-show-right-sidebar':
174+
{x: -160, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true, transform: 'rotate(180deg)'},
175+
'largeicon-hide-right-sidebar':
176+
{x: -192, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true, transform: 'rotate(180deg)'},
175177
'largeicon-show-top-sidebar': {
176178
x: -160,
177179
y: -72,

0 commit comments

Comments
 (0)