Skip to content

Commit 8280e5b

Browse files
author
Philipp Heckel
committed
Do not allow empty messages
1 parent ae97fbe commit 8280e5b

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

server/cache_sqlite.go

+3
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ func (c *sqliteCache) Messages(topic string, since sinceTime) ([]*message, error
6868
if err := rows.Scan(&id, &timestamp, &msg); err != nil {
6969
return nil, err
7070
}
71+
if msg == "" {
72+
msg = " " // Hack: never return empty messages; this should not happen
73+
}
7174
messages = append(messages, &message{
7275
ID: id,
7376
Time: timestamp,

server/server.go

+3
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,9 @@ func (s *Server) handlePublish(w http.ResponseWriter, r *http.Request, v *visito
243243
return err
244244
}
245245
m := newDefaultMessage(t.id, string(b))
246+
if m.Message == "" {
247+
return errHTTPBadRequest
248+
}
246249
if err := t.Publish(m); err != nil {
247250
return err
248251
}

0 commit comments

Comments
 (0)