feat(biome_js_analyze): implement useConsistentObjectDefinition rule

[dy0gu]

Summary

Related: #4816

This PR adds a rule inspired by object-shorthand from eslint. It is not a complete port.

I would also like to add a code action in the future, shouldn't be too hard. I may open a new PR for that but at the moment it would be too time consuming to look into.

Test Plan

Snapshot tests for both the options supported by the rule can be found in crates\biome_js_analyze\tests\specs\nursery\useConsistentObjectLiterals.

[codspeed-hq]

CodSpeed Performance Report

Merging #5042 will not alter performance

_{Comparing dy0gu:use-consistent-object-literals (624c4e3) with next (13869c0)}

Summary

✅ 94 untouched benchmarks

[ematipico]

Overall the code looks good, I left some suggestion. I think we settled on a different name

[ematipico]

A couple of questions and considerations:

• The rule doesn't have any severity, is it intended? FYI rules without severity will have a Information severity
• There many cases that aren't covered by the tests. Do you intend to implement them later or now in this PR?

[ematipico]

We would appreciate if you could provide an example with syntax: "shorthand". Our infrastructure allows you to do that, here the contribution guide that explains how to set it up: https://github.com/biomejs/biome/blob/main/crates/biome_analyze/CONTRIBUTING.md#using-rule-options

[dy0gu]

Just added a ### Valid and ### Invalid section for each syntax option, let me know if it looks good like that so I can resolve this one!

[ematipico]

Options must be documented. These are exposed to our users via JSON Schema, so we need to provide a good description.

[dy0gu]

Sorry but what exactly am I supposed to add in this block you commented? I couldn't find other rules writing documentation there.

[ematipico]

The ESLint rule has an extensive set of tests, we would appreciate we could port some of them.

For example, these cases aren't covered:

const a = {
	"foo": foo, // literal
	"foo": "foo", // right literal,
	['foo']: foo, // computed properties
}

[dy0gu]

Thanks for the link, I took a bunch of their tests and extracted some to cover pretty much all definitions, they have a lot but most are for options or extra features not yet implemented here.

I also updated the actual rule code because there were indeed some cases my rule was missing, that I only saw because of the new tests.

While in the process of that I got to thinking, currently I consider the following as non-shorthandable:

const obj = {
"stringLiteral": "stringLiteral",
"quotedProperty": quotedProperty,
'singleQuoted': singleQuoted,
}

Which is in fact true, because this is NOT valid:

const obj = {
"stringLiteral",
"quotedProperty",
'singleQuoted',
}

However, the ESLint object-shorthand has the option avoidQuotes, which makes it so instead of ignoring the above syntax as non-shorthandable it first recommends using just stringLiteral instead of "stringLiteral", where possible, and then says it can be shorthanded.

I was considering adding this as an option here too but I felt it went a bit against the Biome way since the rule would not be able to be described succinctly anymore. I think another rule like noUnnecessaryPropertyQuotes would be best and would integrate nicely with this one, or maybe we already have one and I just don't know. What do you think @ematipico?