Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js-api): fix the generated types for rule domains #5120

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Feb 13, 2025

Summary

This fixes the generated type for domains in the linter configuration. Now, that type gets emitted is Record<RuleDomain, RuleDomainValue>.

I've tested this on the website repo, and actually both an object and a Map work. I picked Record here since building Maps tends to be a little unergonomic.

Test Plan

@github-actions github-actions bot added A-Project Area: project A-Tooling Area: internal tools labels Feb 13, 2025
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50377 50377 0
Passed 49059 49059 0
Failed 1318 1318 0
Panics 0 0 0
Coverage 97.38% 97.38% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6636 6636 0
Passed 2228 2228 0
Failed 4408 4408 0
Panics 0 0 0
Coverage 33.57% 33.57% 0.00%

ts/babel

Test result main count This PR count Difference
Total 795 795 0
Passed 702 702 0
Failed 93 93 0
Panics 0 0 0
Coverage 88.30% 88.30% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18642 18642 0
Passed 14297 14297 0
Failed 4345 4345 0
Panics 0 0 0
Coverage 76.69% 76.69% 0.00%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@dyc3 dyc3 merged commit d858ffb into main Feb 13, 2025
12 of 13 checks passed
@dyc3 dyc3 deleted the fix-domains-type branch February 13, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants