Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip plots that require marker style or encode OpenCOR's custom style annotations into L1V4 #32

Open
jonrkarr opened this issue Mar 10, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request future

Comments

@jonrkarr
Copy link
Member

Because SED-ML L1V3 doesn't capture plot style, OpenCOR uses custom style annotations in conjunction with L1V3. BioSimulations ignores these custom style annotations. Because style can be critical (e.g., plots can look very different with markers vs lines), we should either:

  1. Use OpenCOR to import these L1V3 files and re-export them to L1V4 with style encoded into SED-ML (if OpenCOR can do this).
  2. For now, skip plots that are annotated with marker styles (because the plot might look very different without lines).
  3. Use lxml or similar to read this information from OpenCOR SED-ML files, encode the style into SED-ML L1V4, and export the file to SED-ML L1V4.

@agarny, could we use OpenCOR for option 1? or will this be possible soon?

@jonrkarr jonrkarr changed the title Skip plots that require marker style or convert OpenCOR's custom style annotations into L1V4 Skip plots that require marker style or encode OpenCOR's custom style annotations into L1V4 Mar 10, 2022
@jonrkarr jonrkarr added enhancement New feature or request future labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future
Projects
None yet
Development

No branches or pull requests

2 participants