Add more pre commit hooks (#348)

bit-bots · Feb 19, 2024 · 1b92026 · 1b92026
2 parents 0b605d7 + d32778d
commit 1b92026
Show file tree

Hide file tree

Showing 32 changed files with 97 additions and 70 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -25,3 +25,11 @@ repos:
     hooks:
       - id: cmake-format
       - id: cmake-lint
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.5.0
+    hooks:
+      - id: check-merge-conflict
+      - id: check-toml
+      - id: check-xml
+      - id: check-yaml
+      - id: detect-private-key
diff --git a/bitbots_behavior/bitbots_blackboard/package.xml b/bitbots_behavior/bitbots_blackboard/package.xml
@@ -15,10 +15,12 @@
 
     <maintainer email="5fiedler@informatik.uni-hamburg.de">Niklas Fiedler</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
     <license>MIT</license>
 
+    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
+
     <build_depend>bitbots_docs</build_depend>
     <depend>bitbots_tf_listener</depend>
     <depend>bitbots_utils</depend>

diff --git a/bitbots_behavior/bitbots_body_behavior/package.xml b/bitbots_behavior/bitbots_body_behavior/package.xml
@@ -7,14 +7,16 @@
         behavior of the robot including strategy decisions and
         kick or walk actions. The node controls the walking indirectly via
         /navigation_goal or directly via /cmd_vel and the head behavior
-        via /head_duty.</description>
+        via /head_duty.
+  </description>
 
   <maintainer email="5fiedler@informatik.uni-hamburg.de">Niklas Fiedler</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
   <license>MIT</license>
 
+  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <depend>bitbots_blackboard</depend>
   <depend>bitbots_msgs</depend>
   <depend>bitbots_utils</depend>

diff --git a/bitbots_lowlevel/bitbots_buttons/package.xml b/bitbots_lowlevel/bitbots_buttons/package.xml
@@ -7,9 +7,11 @@
 
   <maintainer email="5guelden@informatik.uni-hamburg.de">Jasper Güldenstein</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
+
+  <license>MIT</license>
+
   <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
   <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
-  <license>MIT</license>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
   <buildtool_depend>rosidl_default_generators</buildtool_depend>

diff --git a/bitbots_misc/bitbots_basler_camera/package.xml b/bitbots_misc/bitbots_basler_camera/package.xml
@@ -7,9 +7,11 @@
 
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <license>MIT</license>
 
+  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <depend>bitbots_docs</depend>
   <depend>pylon_ros2_camera_wrapper</depend>
   <depend>image_proc</depend>

diff --git a/bitbots_misc/bitbots_bringup/package.xml b/bitbots_misc/bitbots_bringup/package.xml
@@ -7,9 +7,11 @@
 
     <maintainer email="7sell@informatik.uni-hamburg.de">Finn-Thorben Sell</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
     <license>MIT</license>
 
+    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
     <buildtool_depend>ament_cmake</buildtool_depend>
 
     <depend>bitbots_docs</depend>

diff --git a/bitbots_misc/bitbots_ceiling_cam/package.xml b/bitbots_misc/bitbots_ceiling_cam/package.xml
@@ -7,9 +7,11 @@
 
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <license>MIT</license>
 
+  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <depend>bitbots_docs</depend>
   <depend>pylon_ros2_camera_wrapper</depend>
   <depend>image_proc</depend>

diff --git a/bitbots_misc/bitbots_docs/package.xml b/bitbots_misc/bitbots_docs/package.xml
@@ -7,13 +7,15 @@
 
     <maintainer email="7sell@finn-thorben.me">Finn-Thorben Sell</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
     <license>MIT</license>
 
+    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
     <buildtool_depend>ament_cmake</buildtool_depend>
     <build_depend>python3-sphinx-rtd-theme</build_depend>
     <depend>python3-breathe</depend>
-	 
+
 
     <export>
         <bitbots_documentation>

diff --git a/bitbots_misc/bitbots_extrinsic_calibration/package.xml b/bitbots_misc/bitbots_extrinsic_calibration/package.xml
@@ -7,9 +7,10 @@
 
     <maintainer email="florian.vahl@uni-hamburg.de">Florian Vahl</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-    <author email="florian.vahl@uni-hamburg.de">Florian Vahl</author>
 
     <license>MIT</license>
+
+    <author email="florian.vahl@uni-hamburg.de">Florian Vahl</author>
 
     <buildtool_depend>ament_cmake</buildtool_depend>
 

diff --git a/bitbots_misc/bitbots_ipm/package.xml b/bitbots_misc/bitbots_ipm/package.xml
@@ -7,9 +7,11 @@
 
   <maintainer email="florian.vahl@informatik.uni-hamburg.de">Florian Vahl</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <license>MIT</license>
 
+  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <depend>soccer_ipm</depend>
   <depend>ipm_image_node</depend>
   <depend>soccer_vision_3d_rviz_markers</depend>

diff --git a/bitbots_misc/bitbots_robot_description/package.xml b/bitbots_misc/bitbots_robot_description/package.xml
@@ -10,8 +10,10 @@
 
     <maintainer email="git@flova.de">Florian Vahl</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
     <license>MIT</license>
+
+    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
     <buildtool_depend>ament_cmake</buildtool_depend>
 

diff --git a/bitbots_misc/bitbots_teleop/package.xml b/bitbots_misc/bitbots_teleop/package.xml
@@ -7,9 +7,10 @@
 
   <maintainer email="5guelden@informatik.uni-hamburg.de">Jasper Güldenstein</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="5guelden@informatik.uni-hamburg.de">Jasper Güldenstein</author>
-
+
   <license>MIT</license>
+
+  <author email="5guelden@informatik.uni-hamburg.de">Jasper Güldenstein</author>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
 

diff --git a/bitbots_misc/bitbots_tts/package.xml b/bitbots_misc/bitbots_tts/package.xml
@@ -9,9 +9,10 @@
 
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
-
+
   <license>MIT</license>
+
+  <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
 

diff --git a/bitbots_misc/bitbots_utils/package.xml b/bitbots_misc/bitbots_utils/package.xml
@@ -9,8 +9,10 @@
 
     <maintainer email="7sell@informatik.uni-hamburg.de">Finn-Thorben Sell</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
     <license>MIT</license>
+
+    <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
     <buildtool_depend>ament_cmake</buildtool_depend>
 

diff --git a/bitbots_misc/system_monitor/package.xml b/bitbots_misc/system_monitor/package.xml
@@ -9,9 +9,10 @@
 
   <maintainer email="7sell@informatik.uni-hamburg.de">Finn-Thorben Sell</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="7sell@informatik.uni-hamburg.de">Finn-Thorben Sell</author>
 
   <license>MIT</license>
+
+  <author email="7sell@informatik.uni-hamburg.de">Finn-Thorben Sell</author>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
   <depend>std_msgs</depend>

diff --git a/bitbots_motion/bitbots_animation_server/package.xml b/bitbots_motion/bitbots_animation_server/package.xml
@@ -9,11 +9,11 @@
   <maintainer email="6stelter@informatik.uni-hamburg.de">Sebastian Stelter</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
 
+  <license>MIT</license>
+
   <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
   <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
-  <license>MIT</license>
-
   <depend>bitbots_docs</depend>
   <depend>bitbots_msgs</depend>
   <depend>bitbots_robot_description</depend>

diff --git a/bitbots_motion/bitbots_hcm/package.xml b/bitbots_motion/bitbots_hcm/package.xml
@@ -9,12 +9,12 @@
 
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
+
+    <license>MIT</license>
 
   <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
   <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
-  <license>MIT</license>
-
   <buildtool_depend>ament_cmake</buildtool_depend>
 
   <depend>backward_ros</depend>

diff --git a/bitbots_motion/bitbots_head_mover/package.xml b/bitbots_motion/bitbots_head_mover/package.xml
@@ -9,10 +9,11 @@
       point on the field, e.g. to track the ball.</description>
   <maintainer email="valerie.bartel@uni-hamburg.de">Valerie Bartel</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
   <license>MIT</license>
 
+  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <buildtool_depend>ament_cmake</buildtool_depend>
 
   <depend>backward_ros</depend>

diff --git a/bitbots_motion/bitbots_quintic_walk/package.xml b/bitbots_motion/bitbots_quintic_walk/package.xml
@@ -12,12 +12,12 @@
     <maintainer email="7sell@informatik.uni-hamburg.de">Finn-Thorben Sell</maintainer>
     <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
 
+    <license>MIT</license>
+
     <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
     <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
     <author>Rhoban FC (original version of engine)</author>
 
-    <license>MIT</license>
-
     <buildtool_depend>ament_cmake</buildtool_depend>
     <buildtool_depend>rosidl_default_generators</buildtool_depend>
 

diff --git a/bitbots_motion/bitbots_quintic_walk/src/parameters.yaml b/bitbots_motion/bitbots_quintic_walk/src/parameters.yaml
@@ -173,13 +173,6 @@ walking:
         bounds<>: [ 0.0, 1.0 ]
       }
     }
-    trunk_pitch_p_coef_turn: {
-      type: double,
-      description: "Trunk pitch orientation proportional to rotation step (in rad/rad)",
-      validation: {
-        bounds<>: [ -1.0, 1.0 ]
-      }
-    }
     kick_length: {
       type: double,
       description: "Length of kick movement (in meters)",
@@ -347,4 +340,4 @@ walking:
       validation: {
         bounds<>: [ 0.0, 100.0 ],
       }
-    }
+    }
diff --git a/bitbots_motion/bitbots_rl_motion/package.xml b/bitbots_motion/bitbots_rl_motion/package.xml
@@ -8,11 +8,11 @@
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
 
+  <license>MIT</license>
+
   <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
   <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
-  <license>MIT</license>
-
   <buildtool_depend>ament_cmake</buildtool_depend>
 
   <depend>bitbots_docs</depend>

diff --git a/bitbots_motion/bitbots_splines/package.xml b/bitbots_motion/bitbots_splines/package.xml
@@ -8,12 +8,12 @@
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
 
+  <license>MIT</license>
+
   <author email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</author>
   <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
   <author>Rhoban FC</author>
 
-  <license>MIT</license>
-
 
   <buildtool_depend>ament_cmake</buildtool_depend>
   <depend>std_msgs</depend>

diff --git a/bitbots_navigation/bitbots_localization_handler/package.xml b/bitbots_navigation/bitbots_localization_handler/package.xml
@@ -4,14 +4,16 @@
   <name>bitbots_localization_handler</name>
   <version>1.0.0</version>
   <description>
-    The bitbots_localization_handler uses high level information to improve 
+    The bitbots_localization_handler uses high level information to improve
     the localization, e.g. by initializing at the start of the game or after falling down.
   </description>
   <maintainer email="7vahl@informatik.uni-hamburg.de">Florian Vahl</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
-  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <license>MIT</license>
 
+  <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
+
   <depend>bitbots_blackboard</depend>
   <depend>bitbots_localization</depend>
   <depend>bitbots_msgs</depend>
@@ -24,7 +26,7 @@
   <depend>std_msgs</depend>
   <depend>tf2_geometry_msgs</depend>
   <depend>tf2_ros</depend>
-  
+
 
   <export>
     <rosdoc config="rosdoc.yaml" />

diff --git a/bitbots_team_communication/package.xml b/bitbots_team_communication/package.xml
@@ -10,12 +10,12 @@
   <maintainer email="bestmann@informatik.uni-hamburg.de">Marc Bestmann</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
 
+  <license>MIT</license>
+
   <author email="5flemmin@informatik.uni-hamburg.de">Tanja Flemming</author>
   <author email="7engelke@informatik.uni-hamburg.de">Timon Engelke</author>
   <author email="7gutsche@informatik.uni-hamburg.de">Jan Gutsche</author>
 
-  <license>MIT</license>
-
   <buildtool_depend>ament_cmake</buildtool_depend>
 
   <depend>bitbots_docs</depend>

diff --git a/bitbots_vision/package.xml b/bitbots_vision/package.xml
@@ -2,6 +2,9 @@
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
   <name>bitbots_vision</name>
+
+  <version>1.4.1</version>
+
   <description>
     This is the vision ROS package of the Hamburg Bit-Bots.
 
@@ -10,20 +13,18 @@
     For further information and getting started, see the documentation of this package at our website: http://doku.bit-bots.de/package/bitbots_vision/latest/index.html
   </description>
 
-  <version>1.4.1</version>
-
   <maintainer email="7vahl@informatik.uni-hamburg.de">Florian Vahl</maintainer>
   <maintainer email="7gutsche@informatik.uni-hamburg.de">Jan Gutsche</maintainer>
   <maintainer email="info@bit-bots.de">Hamburg Bit-Bots</maintainer>
 
+  <license>MIT</license>
+
   <author email="7vahl@informatik.uni-hamburg.de">Florian Vahl</author>
   <author email="7gutsche@informatik.uni-hamburg.de">Jan Gutsche</author>
   <author email="8hbrandt@informatik.uni-hamburg.de">Hendrik Brandt</author>
   <author email="git@nfiedler.de">Niklas Fiedler</author>
   <author email="info@bit-bots.de">Hamburg Bit-Bots</author>
 
-  <license>MIT</license>
-
   <buildtool_depend>rosidl_default_generators</buildtool_depend>
   <exec_depend>rosidl_default_runtime</exec_depend>
   <depend>bitbots_msgs</depend>
@@ -39,7 +40,7 @@
   <depend>soccer_vision_2d_msgs</depend>
   <depend>std_msgs</depend>
   <depend>vision_opencv</depend>
-  
+
   <export>
     <bitbots_documentation>
       <language>python3</language>