Remove humanoid_league_misc and add caching to tts #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flova
changed the title
Flova
changed the title
|
Testing of the team comm was not successful, but it could be my testing procedure. |
jaagut
reviewed
Feb 1, 2024
|
This does not fully resolve #228, as I would like to improve the spoken text (see issue for that). |
Ah you are right nvm |
jaagut
force-pushed
the
rename-humanoid-league-packages
branch
from
93f47b0 to
2b48470
Compare
jaagut
approved these changes
Feb 4, 2024
Is this resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr moves the last two remaining humanoid league packages out of humanoid_league_mics. They are also renamed accordingly. The team comm is renamed to
bitbots_team_communicationand the speaker is renamed tobitbots_tts, which is a more fitting name imo.. The team comm will also be migrated further into ros sports in the near future, so this is only an intermediate solution.In addition to that caching is added to the tts (as proposed in #228). The outputs are generated at the first call, but persistently stored afterward. I like this approach as it still is quite flexible, while increasing performance overall and being dead simple (supported out of the box by the tts we use).
Proposed changes