Skip to content

bitbox02: update to 6.2.0 #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

benma
Copy link
Contributor

@benma benma commented May 30, 2023

6.2.0 was released to put a minimum requirement on hidapi 0.14.0, which includes the fix for this issue:

libusb/hidapi#531

That bug caused hidapi on macOS 13.3 to report 0 as the interface number for all hid devices, which led to the bitbox02 being listed twice instead of once. This breaks some downstream integrations like Sparrow: sparrowwallet/sparrow#972

6.2.0 was released to put a minimum requirement on hidapi 0.14.0,
which includes the fix for this issue:

libusb/hidapi#531

That bug caused hidapi on macOS 13.3 to report 0 as the interface
number for all hid devices, which led to the bitbox02 being listed
twice instead of once. This breaks some downstream integrations like
Sparrow: sparrowwallet/sparrow#972
@benma
Copy link
Contributor Author

benma commented Jun 25, 2023

Bump @achow101 please merge this and release a new version of HWI 🙏

@achow101
Copy link
Member

Could we do this update as a vendoring of the library rather than keeping it as a dependency? This would let us resolve #675 and bring the bitbox implementation in line with how we handle all other devices.

@benma
Copy link
Contributor Author

benma commented Jul 5, 2023

@achow101 I don't see why not, as long as the vendored code is not modified and can be updated to newer versions without a hassle. Could you make a PR (or update this PR) to vendor it as you see fit?

@achow101 achow101 mentioned this pull request Jul 6, 2023
@achow101
Copy link
Member

Superseded by #683

@achow101 achow101 closed this Jul 18, 2023
achow101 added a commit that referenced this pull request Jul 18, 2023
8888a85 gui: Remove default passphrase (Andrew Chow)
b5ce5e0 bitbox02: Replace installed bitbox02 dep with vendored (Andrew Chow)
753a9d0 bitbox02 lib: Use relative imports and our own base58 (Andrew Chow)
811ea15 deps: Update hidapi to >= 0.14.0 (Andrew Chow)
056a5b5 bitbox02: vendor bitbox02 library (Andrew Chow)
f57f9c3 deps: Add semver, noiseprotocol, and protobuf as explicit deps (Andrew Chow)
674cb08 bitbos02: Use our own base58 implementation (Andrew Chow)
e2d0e63 _base58: Add checksum checking variant of decode (Andrew Chow)

Pull request description:

  This brings the bitbox02 implementation in line with the implementations of the other hardware wallets as we include copies of their respective libraries in our source tree rather than just including them as a dependency. Alternative to #677

  Also an issue with bitbox02 in the GUI is fixed.

  Fixes #675

Top commit has no ACKs.

Tree-SHA512: 71ccc4a3ad17a95396cfd09a7f7195138d426fc5b15e553e1201f74350567adb1263d7b6c1e060839d3ecb37d8b7678f8330f67e4781ea9defe86817dcf088b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants