bitbox02: update to 6.2.0 #677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.2.0 was released to put a minimum requirement on hidapi 0.14.0, which includes the fix for this issue: libusb/hidapi#531 That bug caused hidapi on macOS 13.3 to report 0 as the interface number for all hid devices, which led to the bitbox02 being listed twice instead of once. This breaks some downstream integrations like Sparrow: sparrowwallet/sparrow#972
|
Bump @achow101 please merge this and release a new version of HWI 🙏 |
|
Could we do this update as a vendoring of the library rather than keeping it as a dependency? This would let us resolve #675 and bring the bitbox implementation in line with how we handle all other devices. |
|
@achow101 I don't see why not, as long as the vendored code is not modified and can be updated to newer versions without a hassle. Could you make a PR (or update this PR) to vendor it as you see fit? |
Merged
|
Superseded by #683 |
achow101
added a commit
that referenced
this pull request
Jul 18, 2023
8888a85 gui: Remove default passphrase (Andrew Chow) b5ce5e0 bitbox02: Replace installed bitbox02 dep with vendored (Andrew Chow) 753a9d0 bitbox02 lib: Use relative imports and our own base58 (Andrew Chow) 811ea15 deps: Update hidapi to >= 0.14.0 (Andrew Chow) 056a5b5 bitbox02: vendor bitbox02 library (Andrew Chow) f57f9c3 deps: Add semver, noiseprotocol, and protobuf as explicit deps (Andrew Chow) 674cb08 bitbos02: Use our own base58 implementation (Andrew Chow) e2d0e63 _base58: Add checksum checking variant of decode (Andrew Chow) Pull request description: This brings the bitbox02 implementation in line with the implementations of the other hardware wallets as we include copies of their respective libraries in our source tree rather than just including them as a dependency. Alternative to #677 Also an issue with bitbox02 in the GUI is fixed. Fixes #675 Top commit has no ACKs. Tree-SHA512: 71ccc4a3ad17a95396cfd09a7f7195138d426fc5b15e553e1201f74350567adb1263d7b6c1e060839d3ecb37d8b7678f8330f67e4781ea9defe86817dcf088b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2.0 was released to put a minimum requirement on hidapi 0.14.0, which includes the fix for this issue:
libusb/hidapi#531
That bug caused hidapi on macOS 13.3 to report 0 as the interface number for all hid devices, which led to the bitbox02 being listed twice instead of once. This breaks some downstream integrations like Sparrow: sparrowwallet/sparrow#972