Skip to content

Document missing upstream changes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l0rinc opened this issue Apr 4, 2025 · 2 comments
Open

Document missing upstream changes #49

l0rinc opened this issue Apr 4, 2025 · 2 comments

Comments

@maflcko
Copy link

maflcko commented Apr 4, 2025

According to the leveldb readme:

This repository is receiving very limited maintenance. We will only review the following types of changes.

    Fixes for critical bugs, such as data loss or memory corruption
    Changes absolutely needed by internally supported leveldb clients. These typically fix breakage introduced by a language/standard library/OS update

So I am not sure if they will accept stuff like clang-tidy comments in header files that are basically only relevant to bitcoin core

@l0rinc
Copy link
Author

l0rinc commented Apr 4, 2025

Yes, possible, but if we provide PRs maybe they'll merge it and we don't have to keep track of what we have that they don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants