build: Require C++-17 #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::is_standard_layout_v` (used in `util/no_destructor.h` is not available until C++-17. This breaks building with some compilers. Tested with clang 1f1c725b68b9d72b5cd3fc95c57ce4244bc85c8e (llvm/llvm-project@1f1c725) google#1246 https://en.cppreference.com/w/cpp/types/is_standard_layout.html
|
If we are going to change this, I think you should just change it to C++20. |
|
An alternative would be cherry-picking google#1251 |
|
We aren't trying to retain C++11 compatibility? |
|
You could also update the CMake minimum required to |
|
If this started happening recently in clang, i think we can wait for google to bump theirs (last bump: https://chromium.googlesource.com/chromium/src/tools/clang/+/4e2e7b926a033fc85695da101404f79b7ce2d7a7) and then wait for them to pull in one of the fixes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::is_standard_layout_v(used inutil/no_destructor.his not available until C++-17. This breaks building with some compilers.Tested with clang 1f1c725b68b9d72b5cd3fc95c57ce4244bc85c8e (llvm/llvm-project@1f1c725)
google#1246
https://en.cppreference.com/w/cpp/types/is_standard_layout.html
I ran into this when trying to build with a master
clangto test #54.