Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter on published at #407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dashed
Copy link
Contributor

@dashed dashed commented Mar 23, 2025

This adds time frame selection on published_at datetimes. Inspired by Datadog's timeframe syntax.

Custom timeframe:

Screenshot 2025-03-22 at 10 17 32 PM

Quick presets:

Screenshot 2025-03-22 at 10 18 13 PM

Date range selection:

Screenshot 2025-03-22 at 10 17 49 PM

@dashed dashed force-pushed the upstream/torrent-published-at-filter branch from cdde7c0 to 9a515f0 Compare March 23, 2025 01:41
@mgdigital
Copy link
Collaborator

mgdigital commented Mar 23, 2025

Thanks for making a start on this.
There's too much going on in the backend here- the graphql API should accept only strict ISO-8601 date times and pass it onto go code using the go time types from stdlib.
Anything like "last 7 days" etc can be handled in the web app and passed to the API as a strict date.
If DataDog have provided open-source libs for their date range format I'd be happy to use them but otherwise I don't think we should attempt an implementation of it here as it looks too complex and too much maintenance burden for simply specifying a time range. There are pre-existing date pickers, libraries etc that we should leverage to avoid reinventing wheels, that will greatly simplify things here.
The UI will need planning on how further filters can be added without overcrowding things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants