Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code setting name/namespace overriding secret templates #1547

Closed
wants to merge 1 commit into from
Closed

Remove code setting name/namespace overriding secret templates #1547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/apis/sealedsecrets/v1alpha1/sealedsecret_expansion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,10 +324,6 @@ func (s *SealedSecret) Unseal(codecs runtimeserializer.CodecFactory, privKeys ma
return nil, fmt.Errorf("using deprecated 'data' field, use 'encryptedData' or flip the feature flag")
}

// Ensure these are set to what we expect
secret.SetNamespace(smeta.GetNamespace())
secret.SetName(smeta.GetName())

gvk := s.GetObjectKind().GroupVersionKind()
if anno, ok := s.Spec.Template.Annotations[SealedSecretSkipSetOwnerReferencesAnnotation]; !ok || anno != "true" {
// Refer back to owning SealedSecret
Expand Down