Merge pull request #1253 from maraoz/bn-fromstring

add base to BN.fromString
bitpay · Jun 1, 2015 · 5d77ff7 · 5d77ff7
2 parents 5ee1c3f + 60b07b5
commit 5d77ff7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/crypto/bn.js b/lib/crypto/bn.js
@@ -21,9 +21,9 @@ BN.fromNumber = function(n) {
   return new BN(n);
 };
 
-BN.fromString = function(str) {
+BN.fromString = function(str, base) {
   $.checkArgument(_.isString(str));
-  return new BN(str);
+  return new BN(str, base);
 };
 
 BN.fromBuffer = function(buf, opts) {

diff --git a/test/crypto/bn.js b/test/crypto/bn.js
@@ -79,6 +79,10 @@ describe('BN', function() {
     it('should make BN from a string', function() {
       BN.fromString('5').toString().should.equal('5');
     });
+    it('should work with hex string', function() {
+      BN.fromString('7fffff0000000000000000000000000000000000000000000000000000000000', 16)
+      .toString(16).should.equal('7fffff0000000000000000000000000000000000000000000000000000000000');
+    });
   });
 
   describe('#toString', function() {