Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable Transaction Optimization #1210

Closed
braydonf opened this issue May 1, 2015 · 2 comments
Closed

Immutable Transaction Optimization #1210

braydonf opened this issue May 1, 2015 · 2 comments

Comments

@braydonf
Copy link
Contributor

braydonf commented May 1, 2015

If the Transaction class had an immutable option during construction, it would be possible to cache the serialized version of the transaction to optimize performance of calling toBuffer() and computing the hash of the transaction. Likewise it may also be possible to cache the buffer automatically, and then upon any update clear the cache to cause the buffer to regenerate.
@maraoz
Copy link
Contributor

maraoz commented May 5, 2015

good idea

This was referenced May 6, 2015
Open
Closed
@braydonf
Copy link
Contributor Author

Merging with: #1224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maraoz @braydonf