use SDK provided state instead

Author: mpbw2

app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt

@@ -31,7 +31,6 @@ import com.x8bit.bitwarden.ui.vault.feature.item.model.VaultItemStateData
 import com.x8bit.bitwarden.ui.vault.feature.item.util.toViewState
 import com.x8bit.bitwarden.ui.vault.feature.util.canAssignToCollections
 import com.x8bit.bitwarden.ui.vault.feature.util.hasDeletePermissionInAtLeastOneCollection
-import com.x8bit.bitwarden.ui.vault.feature.util.hasEditPermissionInAtLeastOneCollection
 import com.x8bit.bitwarden.ui.vault.model.VaultCardBrand
 import com.x8bit.bitwarden.ui.vault.model.VaultLinkedFieldType
 import dagger.hilt.android.lifecycle.HiltViewModel
@@ -117,18 +116,11 @@ class VaultItemViewModel @Inject constructor(
                             .data
                             .canAssignToCollections(cipherViewState.data?.collectionIds)
 
-                        val canEdit = collectionsState
-                            .data
-                            .hasEditPermissionInAtLeastOneCollection(
-                                cipherViewState.data?.collectionIds,
-                            )
-
                         VaultItemStateData(
                             cipher = cipherViewState.data,
                             totpCodeItemData = totpCodeData,
                             canDelete = canDelete,
                             canAssociateToCollections = canAssignToCollections,
-                            canEdit = canEdit,
                         )
                     },
             )
@@ -1048,7 +1040,6 @@ class VaultItemViewModel @Inject constructor(
                 totpCodeItemData = this.data?.totpCodeItemData,
                 canDelete = this.data?.canDelete == true,
                 canAssignToCollections = this.data?.canAssociateToCollections == true,
-                canEdit = this.data?.canEdit == true,
             )
         }
         ?: VaultItemState.ViewState.Error(message = errorText)
@@ -1289,7 +1280,8 @@ data class VaultItemState(
     private val isCipherEditable: Boolean
         get() = viewState.asContentOrNull()
             ?.common
-            ?.canEdit == true
+            ?.currentCipher
+            ?.edit == true
 
     /**
      * Whether or not the fab is visible.
@@ -1391,7 +1383,6 @@ data class VaultItemState(
                 val attachments: List<AttachmentItem>?,
                 val canDelete: Boolean,
                 val canAssignToCollections: Boolean,
-                val canEdit: Boolean,
             ) : Parcelable {
 
                 /**

app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/model/VaultItemStateData.kt

@@ -9,12 +9,10 @@ import com.bitwarden.vault.CipherView
  * @property totpCodeItemData The data for the totp code.
  * @property canDelete Whether the item can be deleted.
  * @property canAssociateToCollections Whether the item can be associated to a collection.
- * @property canEdit Whether the item can be edited.
  */
 data class VaultItemStateData(
     val cipher: CipherView?,
     val totpCodeItemData: TotpCodeItemData?,
     val canDelete: Boolean,
     val canAssociateToCollections: Boolean,
-    val canEdit: Boolean,
 )

app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt

@@ -41,7 +41,6 @@ fun CipherView.toViewState(
     clock: Clock = Clock.systemDefaultZone(),
     canDelete: Boolean,
     canAssignToCollections: Boolean,
-    canEdit: Boolean,
 ): VaultItemState.ViewState =
     VaultItemState.ViewState.Content(
         common = VaultItemState.ViewState.Content.Common(
@@ -84,7 +83,6 @@ fun CipherView.toViewState(
                 .orEmpty(),
             canDelete = canDelete,
             canAssignToCollections = canAssignToCollections,
-            canEdit = canEdit,
         ),
         type = when (type) {
             CipherType.LOGIN -> {

app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensions.kt

@@ -122,20 +122,3 @@ fun List<CollectionView>?.canAssignToCollections(currentCollectionIds: List<Stri
             itemIsInCollection && (!it.manage || it.readOnly)
         }
         ?: true
-
-/**
- * Checks if the user has edit permission in at least one collection.
- *
- * Editing is allowed when the item is in any collection that isn't read-only.
- */
-fun List<CollectionView>?.hasEditPermissionInAtLeastOneCollection(
-    collectionIds: List<String>?,
-): Boolean {
-    if (this.isNullOrEmpty() || collectionIds.isNullOrEmpty()) return true
-    return this
-        .any { collectionView ->
-            collectionIds
-                .contains(collectionView.id)
-                .let { isInCollection -> isInCollection && !collectionView.readOnly }
-        }
-}

app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt

@@ -2698,7 +2698,6 @@ private val DEFAULT_COMMON: VaultItemState.ViewState.Content.Common =
         ),
         canDelete = true,
         canAssignToCollections = true,
-        canEdit = true,
     )
 
 private val DEFAULT_PASSKEY = R.string.created_xy.asText(
@@ -2782,7 +2781,6 @@ private val EMPTY_COMMON: VaultItemState.ViewState.Content.Common =
         attachments = emptyList(),
         canDelete = true,
         canAssignToCollections = true,
-        canEdit = true,
     )
 
 private val EMPTY_LOGIN_TYPE: VaultItemState.ViewState.Content.ItemType.Login =