-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL text direction #4753
Comments
Thank you for your report! We've added this to our internal board for review. |
Please take a look at my proposed fix for the same problem in KeePassDX: Kunzisoft/KeePassDX@750e1b6 I have not looked into the Bitwarden codebase but I believe it should be easy to adapt such a change. I would have opened a PR myself if it was possible to set up Bitwarden in Android Studio without setting up a server as well. |
Hi @codokie, |
@SaintPatrck There is no error but it asks me to log in to a Bitwarden account. Is there a way to use the debug app without doing so? If not, I guess I could create a dummy account just for testing purposes.. Edit: There would also be a need to test the text direction of the OTP codes which is a Premium feature.. |
No, an account is required. You can log into your regular account or create a new one if you're not comfortable using your regular account. |
Steps To Reproduce
To reproduce the bug with a vault item:
_user
pass*
https://bitwarden.com/
(don't forget the ending slash)$custom-text@#
To reproduce the bug with the password generator:
Expected Result
The username, password, URL, and custom field of a vault item should appear exactly as they were typed.
The generated password that is displayed in the Password Generator should be identical to the copied password.
Actual Result
The details of the vault item appear as follows:
user_
*pass
/https://bitwarden.com
#@custom-text$
Notice that the special characters at the start and end of each field have been reversed (same thing happens with the Password Generator).
Additional Context
The bug most likely happens because the direction of text fields automatically follows the direction of the layout (RTL).
This behavior is unwanted because it causes confusion and error when copying a displayed field visually.
Most websites do not allow passwords or usernames to contain RTL scripts, and when such characters appear in a URL, they must be (percent) encoded. So there is no benefit to apply an RTL direction to such fields.
Note that the RTL text direction is desired in the notes field of a login vault item as well as in a secure note and in the various fields of an identity vault item, because they are more likely to be written from right-to-left. So the current behavior should remain unchanged for them.
Lastly, it should be noted that the password and text fields of a Send are also affected.
UPDATE: It seems that this issue is present in the master password input field as well!
Build Version
2025.1.2
Environment Details
Issue Tracking Info
The text was updated successfully, but these errors were encountered: