Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-18877 Respect system app specific language selection on Android 13 and up. #4849

Merged
merged 1 commit into from
Mar 13, 2025
Merged

PM-18877 Respect system app specific language selection on Android 13 and up. #4849

merged 1 commit into from
Mar 13, 2025

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Mar 11, 2025 •
edited by SaintPatrck
Loading

🎟️ Tracking

#4813
#4833
PM-18877

📔 Objective

  • When a user makes a selection for an app specific language through the device settings (Android 13+), we want to respect that setting and update the internal storage to reflect those changes.
  • If the user sets an app specific language from the device settings currently, that selection will not be persisted across app restart as it was not being saved.
  • There was also a case where, if the user had set a language in the app's appearance settings and then made a new selection in the device settings it would not be reflected.
  • For devices where App specific language APIs are available we will check the API when the app resumes and if one is selected we will save to the storage to keep in sync.

📸 Screenshots

BEFORE

before18877.mp4

AFTER

after18877.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (1eb741a) to head (528f4a9).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4849      +/-   ##
==========================================
- Coverage   89.36%   84.02%   -5.34%     
==========================================
  Files         496      616     +120     
  Lines       42254    47989    +5735     
  Branches     5990     6677     +687     
==========================================
+ Hits        37759    40323    +2564     
- Misses       2421     5409    +2988     
- Partials     2074     2257     +183

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 1f5bd289-cd45-4ae3-a74b-7960621dc149

Great job, no security vulnerabilities found in this Pull Request

phil-livefront
phil-livefront reviewed Mar 12, 2025
View reviewed changes
app/src/test/java/com/x8bit/bitwarden/ui/platform/util/LocaleExtensionsTest.kt

@Test
fun `locale with non existent app language returns null`() {
val locale = Locale("😅😅😅")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@dseverns-livefront dseverns-livefront added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit ca64ce2 Mar 13, 2025
14 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-18877-respect-app-specific-language branch March 13, 2025 13:38
@SaintPatrck SaintPatrck linked an issue Mar 25, 2025 that may be closed by this pull request
Android app using wrong language #4833
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-livefront david-livefront david-livefront approved these changes

@phil-livefront phil-livefront phil-livefront approved these changes

@brian-livefront brian-livefront Awaiting requested review from brian-livefront brian-livefront is a code owner

@ahaisting-livefront ahaisting-livefront Awaiting requested review from ahaisting-livefront

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android app using wrong language
3 participants
@dseverns-livefront @david-livefront @phil-livefront