Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty word separator in passphrase generator still separates with space #4913

Open
1 task done
Arjun42 opened this issue Mar 25, 2025 · 7 comments
Open
1 task done

Comments

@Arjun42
Copy link

Arjun42 commented Mar 25, 2025

Steps To Reproduce

  1. Go to 'Generator' bottom tab
  2. Click on 'Passphrase' top tab
  3. Select 'Word separator' field and remove all characters

Expected Result

Words in passphrase should not be separated by spaces or any other characters.

Actual Result

Words in passphrase are separated by a space.

Screenshots or Videos

Screen_Recording_20250324_203816_Bitwarden.mp4

Additional Context

This works as expected on Bitwarden's Windows app, Firefox extension, and iOS app.

Build Version

2025.2.0 (19883)

What server are you connecting to?

US

Self-host Server Version

No response

Environment Details

Device: Samsung Galaxy Fold 4
OS: One UI 6.1.1 (Android 14)

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@S-Kakar
Copy link

S-Kakar commented Mar 25, 2025

Thank you for your report! We've added this to our internal board for review.
ID: PM-19476

@daniellbw
Copy link

Hi there,

Your issue appears to be describing the intended behavior of the software. If you want this to be changed, it would be a feature request.

We use GitHub issues as a place to track bugs and other development related issues. The Bitwarden Community Forums has a Feature Requests section for submitting, voting for, and discussing requests like this one: https://community.bitwarden.com/c/feature-requests/

Please sign up on our forums (https://community.bitwarden.com/signup) and search to see if this request already exists. If so, you can vote for it and contribute to any discussions about it. If not, you can re-create the request there so that it can be properly tracked.

This issue will now be closed.

Thanks!

@daniellbw daniellbw closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2025
@pamperer562580892423
Copy link

pamperer562580892423 commented Mar 25, 2025

@daniellbw How is choosing "no letter or special character at all" between the passphrase words, but getting an unwanted space character inserted between the words the intended behaviour of the software?

To get something else as the setting I choose indicates, seems very clearly like a bug.

@Arjun42
Copy link
Author

Arjun42 commented Mar 25, 2025

Thanks for the vote of confidence, @pamperer562580892423 .

@daniellbw I had already created a post on the Bitwarden Community forum and received feedback there that others are experiencing the same bug: https://community.bitwarden.com/t/empty-word-separator-in-passphrase-generator-still-separates-with-space/83071

Note that it works as expected on other platforms as noted in the above bug report. It's fine on the Windows app, Firefox extension, and iOS app. But it does not work as expected on the Android app.

I hope you can re-open the issue and provide another update.

Cheers!

@LougheadL
Copy link

@daniellbw, how is this intended behaviour? The user is indicating that the separator should be a zero-length string, yet it is inserting a space. If intended, then why did you intend that?

@pamperer562580892423
Copy link

pamperer562580892423 commented Mar 25, 2025

@daniellbw Having a different outcome only on the Android app, with the same settings as in the other apps (NO separator chosen), qualifies as a bug, I think - and can't be "intended". If it is intended, I would like to have an explanation, how this can be intended.

Here I would like to visualize the different outcomes in the different apps, as @Arjun42 already mentioned:

(for comparison, I chose the same settings now for every generator - 5 words, with Capizalization, Number included, and NO separator)

 

Chromium-based browser extension 2025.3.0 - no separator chosen, no separator used in the generated phrase:

Image

 

Web Vault 2025.3.0 - no separator chosen, no separator used in the generated phrase:

Image

 

Desktop App 2025.2.1 - no separator chosen, no separator used in the generated phrase:

Image

 

Android App 2025.2.0 - no separator chosen, BUT SPACE AS SEPARATOR used in the generated phrase:

Image

@daniellbw daniellbw reopened this Mar 26, 2025
@daniellbw
Copy link

Hi @pamperer562580892423 and @Arjun42

Thank you for bringing this to our attention and all the information attached, I've notified our Engineering team of this inconsistent behaviour accross our clients and have reopened this github issue.

Again, thank you for all the relevant information provided!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants