-
Notifications
You must be signed in to change notification settings - Fork 866
[PM-13349] Hide edit button unless item is in at least one non-readOnly collection #4430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The server evaluates this business logic for you and sets the result in the cipher.edit
property.
true
if the user can edit the itemfalse
if the item is read-only
This takes into account whether it's in the user's individual vault vs. organization (and if organization, what collection permissions apply).
I'm not familiar with mobile, but it looks like it's available on the SDK model: https://github.com/bitwarden/sdk-internal/blob/main/crates/bitwarden-vault/src/cipher/cipher.rs#L82
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4430 +/- ##
==========================================
- Coverage 88.87% 88.86% -0.02%
==========================================
Files 460 460
Lines 39899 39907 +8
Branches 5685 5690 +5
==========================================
+ Hits 35462 35465 +3
Misses 2457 2457
- Partials 1980 1985 +5 ☔ View full report in Codecov by Sentry. |
Thanks for the heads up on this @eliykat |
Hide edit button unless item is in at least one non-readOnly collection
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13349
📔 Objective
Hide the edit button (FAB) if an item is in a readOnly collection, or in the case of multiple collections at least one has to be non-readOnly or the button remains hidden.
📸 Screenshots
Item view from within non-readOnly (editable) collection:
Item view from within readOnly (non-editable) collection:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes