[PM-12391] Respect PIN unlock setting during FIDO user verification

[SaintPatrck]

🎟️ Tracking

PM-12391

📔 Objective

Check the isUnlockWithPinEnabled setting instead of checking the vaultUnlockType of the active account to determine if a PIN prompt should be shown.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 45cb27ec-5afa-4e91-9d3a-42588e8ab8b6

No New Or Fixed Issues Found

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (3329dfa) to head (db7fa73).
Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4483   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         455      455           
  Lines       39558    39558           
  Branches     5605     5605           
=======================================
  Hits        35173    35173           
  Misses       2428     2428           
  Partials     1957     1957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dseverns-livefront]

This looks good for this fix and seems to be inline with how we are checking this elsewhere. I am wondering if we should update this in AuthRepositoryImpl

// from 
private fun getVaultUnlockType(
        userId: String,
    ): VaultUnlockType =
        when {
            authDiskSource.getPinProtectedUserKey(userId = userId) != null -> {
                VaultUnlockType.PIN
            }

            else -> {
                VaultUnlockType.MASTER_PASSWORD
            }
        }

// to 
private fun getVaultUnlockType(
        userId: String,
    ): VaultUnlockType =
        when {
            authDiskSource.getEncryptedPin(userId = userId) != null -> {
                VaultUnlockType.PIN
            }


            else -> {
                VaultUnlockType.MASTER_PASSWORD
            }
        }

since that seems to be the delta on why that value was not working when getting from the user state vs the settings repository. I am not sure if there is a specific reason for this difference though so may be safer to not touch it for this change.

[SaintPatrck]

I like that suggestion. Like you say, we'll need to make sure it doesn't have any negative downstream effects. I'll create a ticket to revisit this for a broader improvement later and we can go forward with this fix in the interim.