[PM-19905] Migrate DispatcherManager to data module
#4999
Merged
+99
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
SaintPatrck
force-pushed
the
data-module/dispatcher-manager
branch
from
7cf0287 to
4b05740
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
==========================================
+ Coverage 81.31% 83.94% +2.63%
==========================================
Files 1073 588 -485
Lines 58746 47899 -10847
Branches 7206 6617 -589
==========================================
- Hits 47767 40209 -7558
+ Misses 8453 5452 -3001
+ Partials 2526 2238 -288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
authenticator/remove-unused-featureflag-repo
to
main
April 7, 2025 13:13
SaintPatrck
force-pushed
the
data-module/dispatcher-manager
branch
from
4b05740 to
f6c5a8b
Compare
SaintPatrck
requested review from
brian-livefront,
david-livefront and
a team
as code owners
| @@ -15,7 +15,7 @@ class DispatcherManagerTest { | |||
|
|
|||
| val actual = dispatcherManager.io | |||
|
|
|||
| assertEquals(expected, actual) | |||
| Assertions.assertEquals(expected, actual) | |||
There was a problem hiding this comment.
Ah. Nice catch. Yes.
Move `DispatcherManager` and its implementation to the `data` module. Additionally, `FakeDispatcherManager` was moved to `data.testFixtures` for reusability.
SaintPatrck
force-pushed
the
data-module/dispatcher-manager
branch
from
f6c5a8b to
e23df6f
Compare
david-livefront
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-19905
📔 Objective
Move
DispatcherManagerand its implementation to thedatamodule.Additionally,
FakeDispatcherManagerwas moved todata.testFixturesfor reusability.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes