Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-19947] Provide system clock in the core module #5000

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 4, 2025

🎟️ Tracking

PM-19947

📔 Objective

The system Clock provider has been moved to the core module.

This change removes redundant Clock providers from authenticator and app modules.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck marked this pull request as draft April 4, 2025 21:12
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Logo
Checkmarx One – Scan Summary & Details1f0eb9e6-9dc0-465e-82e3-d53eadfc1d04

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (942f6e2) to head (eed184b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5000   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files         588      588           
  Lines       47917    47917           
  Branches     6619     6619           
=======================================
  Hits        40226    40226           
  Misses       5452     5452           
  Partials     2239     2239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck force-pushed the data-module/dispatcher-manager branch from 4b05740 to f6c5a8b Compare April 7, 2025 15:41
@SaintPatrck SaintPatrck changed the title Provide system clock in the core module [PM-19947] Provide system clock in the core module Apr 7, 2025
@SaintPatrck SaintPatrck force-pushed the data-module/dispatcher-manager branch from f6c5a8b to e23df6f Compare April 7, 2025 18:11
Base automatically changed from data-module/dispatcher-manager to main April 7, 2025 18:44
Move `DispatcherManager` and its implementation to the `data` module.

Additionally, `FakeDispatcherManager` was moved to `data.testFixtures` for reusability.
@SaintPatrck SaintPatrck force-pushed the core-module/provide-clock branch from 99f6209 to b603904 Compare April 7, 2025 19:37
@SaintPatrck SaintPatrck marked this pull request as ready for review April 7, 2025 19:37
The system `Clock` provider has been moved to the `core` module.

This change removes redundant `Clock` providers from `authenticator` and `app` modules.
@SaintPatrck SaintPatrck force-pushed the core-module/provide-clock branch from b603904 to eed184b Compare April 7, 2025 19:38
@SaintPatrck SaintPatrck enabled auto-merge April 7, 2025 19:43
@SaintPatrck SaintPatrck added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 1df96fd Apr 7, 2025
7 of 8 checks passed
@SaintPatrck SaintPatrck deleted the core-module/provide-clock branch April 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants