-
Notifications
You must be signed in to change notification settings - Fork 1.4k
BRE-536/Add-ARM-targz-builds-for-desktop-and-cli #14270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRE-536/Add-ARM-targz-builds-for-desktop-and-cli #14270
Conversation
…s-for-desktop-client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- apps/cli/package.json: Language not supported
- apps/desktop/package.json: Language not supported
Comments suppressed due to low confidence (3)
apps/desktop/desktop_native/build.js:51
- A new ARM64 target is added; please add corresponding tests to ensure that the ARM64 build process works as intended.
['aarch64-unknown-linux-musl', 'arm64']
.github/workflows/build-desktop.yml:309
- Verify that the 'ubuntu-22.04-arm' runner is supported by GitHub Actions; if not, update the runner label to prevent potential workflow failures.
runs-on: ubuntu-22.04-arm
.github/workflows/build-cli.yml:99
- Ensure that the conditional runner assignment works as expected for all entries in the build matrix to avoid unintended runner mismatches.
runs-on: ${{ matrix.os.runner || matrix.os.distro }}
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14270 +/- ##
==========================================
- Coverage 36.88% 36.87% -0.01%
==========================================
Files 3202 3213 +11
Lines 92454 92648 +194
Branches 16579 16632 +53
==========================================
+ Hits 34103 34166 +63
- Misses 55937 56061 +124
- Partials 2414 2421 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looking forward to ARM support on Linux!
I mostly just have a few formatting nits and a question:
|
closed and reopened to run workflow linter again |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-536
📔 Objective
update our desktop and CLI build workflows to produce a Linux build compatible with ARM64 arch. This first ticket will be adding a tar.gz package type only for desktop, and the regular binary no snap for CLI. Additional types will be added in subsequent work
Updated the build.js file to allow for more flexibility and specifying arch while maintaining functionality of existing
cross-platform
call being used elsewhere in the workflow⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes