Skip to content

[PM-20118] Capitalize risk insights #14291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

voommen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/issues/PM-20118?filter=11401

📔 Objective

Two changes:

  1. Capitalize "Risk Insights" (for english)
  2. Hide the "Data refresh..." block until there is data to be displayed

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@voommen-livefront voommen-livefront requested a review from a team as a code owner April 15, 2025 14:32
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.88%. Comparing base (9f174e7) to head (a710705).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14291   +/-   ##
=======================================
  Coverage   36.87%   36.88%           
=======================================
  Files        3210     3210           
  Lines       92568    92565    -3     
  Branches    16610    16612    +2     
=======================================
+ Hits        34137    34143    +6     
+ Misses      56017    56008    -9     
  Partials     2414     2414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@voommen-livefront voommen-livefront changed the title PM-20118 capitalize risk insights [PM-20118] Capitalize risk insights Apr 15, 2025
Copy link
Contributor

github-actions bot commented Apr 15, 2025

Logo
Checkmarx One – Scan Summary & Detailsf266d422-0c33-47ac-978c-81505a6bc0c7

Great job, no security vulnerabilities found in this Pull Request

@voommen-livefront voommen-livefront merged commit 9cffc3b into main Apr 16, 2025
48 of 49 checks passed
@voommen-livefront voommen-livefront deleted the dirt/pm-20118/capitalize-risk-insights branch April 16, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants