Propose ADR for using TryAdd in .NET dependency injection
#606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justindbaur
commented
May 31, 2025
| @@ -94,7 +94,7 @@ It may sometimes be needed to assert to the compiler that you know something is | |||
| it thinks it might be - to do that you can use the [`!` operator][null-forgiving]. You may want to | |||
| do this for properties that you know are populated elsewhere; for example: | |||
|
|
|||
| ```c# | |||
| ```csharp | |||
There was a problem hiding this comment.
When writing this ADR I realized c# doesn't make syntax highlighting work in our docs only csharp. Even though c# does work in GitHub.
Deploying contributing-docs with
|
| Latest commit: |
8909941
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a7de5539.contributing-docs.pages.dev |
| Branch Preview URL: | https://adr-try-add-dependency-injec.contributing-docs.pages.dev |
justindbaur
changed the title
TryAdd in .NET dependency injection
|
Great job, no security vulnerabilities found in this Pull Request |
withinfocus
requested changes
Jun 4, 2025
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr/0026-dotnet-dependency-injection-enhancements.md
Outdated
Show resolved
Hide resolved
| occasionally throughout the codebase but they is no outside encouragement to use them. | ||
| - **Encourage usage** - Start encouraging usage through team training and encouragement to use them | ||
| in code reviews but don't make any automatic check to enforce usage. | ||
| - **Enforce usage** - Start enforcing usage of `TryAdd` overloads by adding the |
There was a problem hiding this comment.
💭 My one non-suggestion comment: what if we went this way? Do we get other benefits long-term? The plan here could be two-stage and we introduce this later.
Co-authored-by: Matt Bishop <matt@withinfocus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
Add ADR for encouraging use of
TryAddoverloads in .NET dependency injection.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes