Skip to content

[PM-18708] Change G Suite property name in example to match the docs #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18708

📔 Objective

The linked Jira is not really an issue, the example just shows the wrong g suite for OUs. This PR updates the copy to use the correct property. Otherwise the User filter works as expected.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner April 14, 2025 19:57
@BTreston BTreston requested a review from JimmyVo16 April 14, 2025 19:57
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsdba1b774-5a70-4b4d-979f-05e3f2513801

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-31486 Npm-vite-5.1.8
detailsDescription: A vulnerability in Vite allows the contents of arbitrary files to be returned to the browser. By appending "?.svg" along with "?.wasm?init" or sett...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: KA%2BzQT%2BAKELLRn1ruSNphrnAQi1wM8h7%2FwBAaegDLPw%3D
Vulnerable Package

@BTreston BTreston merged commit 23d285a into main Apr 15, 2025
14 of 17 checks passed
@BTreston BTreston deleted the ac/pm-18708-update-copy-for-User-Filter-on-G-Suite-directory-connections branch April 15, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants