[PM-20366] Add pre-login settings button to landing screen (#1555)

Author: matt-livefront

BitwardenShared/Core/Platform/Models/Enum/FeatureFlag.swift

@@ -59,6 +59,12 @@ extension FeatureFlag: @retroactive CaseIterable {
     /// A feature flag for the create account flow.
     static let nativeCreateAccountFlow = FeatureFlag(rawValue: "native-create-account-flow")
 
+    /// A feature flag for the pre-login settings.
+    static let preLoginSettings = FeatureFlag(
+        rawValue: "enable-pm-prelogin-settings",
+        isRemotelyConfigured: false
+    )
+
     /// A feature flag for the refactor on the SSO details endpoint.
     static let refactorSsoDetailsEndpoint = FeatureFlag(rawValue: "pm-12337-refactor-sso-details-endpoint")
 
@@ -85,6 +91,7 @@ extension FeatureFlag: @retroactive CaseIterable {
             .importLoginsFlow,
             .mobileErrorReporting,
             .nativeCreateAccountFlow,
+            .preLoginSettings,
             .refactorSsoDetailsEndpoint,
             .restrictCipherItemDeletion,
             .simpleLoginSelfHostAlias,

BitwardenShared/Core/Platform/Models/Enum/FeatureFlagTests.swift

@@ -29,5 +29,6 @@ final class FeatureFlagTests: BitwardenTestCase {
         XCTAssertFalse(FeatureFlag.flightRecorder.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.ignore2FANoticeEnvironmentCheck.isRemotelyConfigured)
         XCTAssertFalse(FeatureFlag.mobileErrorReporting.isRemotelyConfigured)
+        XCTAssertFalse(FeatureFlag.preLoginSettings.isRemotelyConfigured)
     }
 }

BitwardenShared/UI/Auth/Landing/LandingAction.swift

@@ -14,6 +14,9 @@ enum LandingAction: Equatable {
     /// The value for the remember me toggle was changed.
     case rememberMeChanged(Bool)
 
+    /// Show the pre-login app settings.
+    case showPreLoginSettings
+
     /// The toast was shown or hidden.
     case toastShown(Toast?)
 }

BitwardenShared/UI/Auth/Landing/LandingProcessor.swift

@@ -96,6 +96,9 @@ class LandingProcessor: StateProcessor<LandingState, LandingAction, LandingEffec
             if !newValue {
                 updateRememberedEmail()
             }
+        case .showPreLoginSettings:
+            // TODO: BIT-20367 Show Pre-Login Settings
+            break
         case let .toastShown(toast):
             state.toast = toast
         }
@@ -122,6 +125,10 @@ class LandingProcessor: StateProcessor<LandingState, LandingAction, LandingEffec
             defaultValue: false,
             isPreAuth: true
         )
+        state.isPreLoginSettingsEnabled = await services.configService.getFeatureFlag(
+            .preLoginSettings,
+            isPreAuth: true
+        )
     }
 
     /// Validate the currently entered email address and navigate to the login screen.

BitwardenShared/UI/Auth/Landing/LandingProcessorTests.swift

@@ -143,28 +143,34 @@ class LandingProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_
     @MainActor
     func test_perform_appeared_loadsFeatureFlag_true() async {
         configService.featureFlagsBoolPreAuth[.emailVerification] = true
+        configService.featureFlagsBoolPreAuth[.preLoginSettings] = true
         subject.state.emailVerificationFeatureFlag = false
+        subject.state.isPreLoginSettingsEnabled = false
 
         let task = Task {
             await subject.perform(.appeared)
         }
         await task.value
         XCTAssertEqual(configService.configMocker.invokedParam?.isPreAuth, true)
         XCTAssertTrue(subject.state.emailVerificationFeatureFlag)
+        XCTAssertTrue(subject.state.isPreLoginSettingsEnabled)
     }
 
     /// `perform(.appeared)` with feature flag for .emailVerification set to false
     @MainActor
     func test_perform_appeared_loadsFeatureFlag_false() async {
         configService.featureFlagsBoolPreAuth[.emailVerification] = false
+        configService.featureFlagsBoolPreAuth[.preLoginSettings] = false
         subject.state.emailVerificationFeatureFlag = true
+        subject.state.isPreLoginSettingsEnabled = true
 
         let task = Task {
             await subject.perform(.appeared)
         }
         await task.value
         XCTAssertEqual(configService.configMocker.invokedParam?.isPreAuth, true)
         XCTAssertFalse(subject.state.emailVerificationFeatureFlag)
+        XCTAssertFalse(subject.state.isPreLoginSettingsEnabled)
     }
 
     /// `perform(.appeared)` with feature flag defaulting to false
@@ -179,6 +185,7 @@ class LandingProcessorTests: BitwardenTestCase { // swiftlint:disable:this type_
         await task.value
         XCTAssertEqual(configService.configMocker.invokedParam?.isPreAuth, true)
         XCTAssertFalse(subject.state.emailVerificationFeatureFlag)
+        XCTAssertFalse(subject.state.isPreLoginSettingsEnabled)
     }
 
     /// `perform(.appeared)` with an active account and accounts should yield a profile switcher state.

BitwardenShared/UI/Auth/Landing/LandingState.swift

@@ -15,6 +15,9 @@ struct LandingState: Equatable {
         !email.isEmpty
     }
 
+    /// Whether the pre-login settings feature flag is enabled.
+    var isPreLoginSettingsEnabled = false
+
     /// A flag indicating if the "Remember Me" toggle is on.
     var isRememberMeOn: Bool
 

BitwardenShared/UI/Auth/Landing/LandingView.swift

@@ -150,6 +150,16 @@ struct LandingView: View {
                 Spacer()
             }
             .styleGuide(.footnote)
+
+            if store.state.isPreLoginSettingsEnabled {
+                Button {
+                    store.send(.showPreLoginSettings)
+                } label: {
+                    Label(Localizations.appSettings, image: Asset.Images.cog16.swiftUIImage)
+                }
+                .buttonStyle(.bitwardenBorderless)
+                .frame(maxWidth: .infinity, alignment: .center)
+            }
         }
     }
 }

BitwardenShared/UI/Auth/Landing/LandingViewTests.swift

@@ -31,6 +31,15 @@ class LandingViewTests: BitwardenTestCase {
 
     // MARK: Tests
 
+    /// Tapping the app settings button dispatches the `.showPreLoginSettings` action.
+    @MainActor
+    func test_appSettings_tap() throws {
+        processor.state.isPreLoginSettingsEnabled = true
+        let button = try subject.inspect().find(button: Localizations.appSettings)
+        try button.tap()
+        XCTAssertEqual(processor.dispatchedActions.last, .showPreLoginSettings)
+    }
+
     /// The continue button should be disabled when there is no value in the email field.
     @MainActor
     func test_continueButton_disabled() throws {
@@ -99,6 +108,7 @@ class LandingViewTests: BitwardenTestCase {
     /// Check the snapshot for the empty state.
     @MainActor
     func test_snapshot_empty() {
+        processor.state.isPreLoginSettingsEnabled = true
         assertSnapshots(of: subject, as: [.defaultPortrait, .defaultPortraitDark, .defaultPortraitAX5])
     }
 

BitwardenShared/UI/Auth/Landing/__Snapshots__/LandingViewTests/test_snapshot_empty.1.png

@@ -1180,3 +1180,4 @@
 "KeyConnectorConfirmDomainWithAdmin" = "Please confirm the domain below with your organization administrator.\n\nKey Connector domain:\n%1$@";
 "DoYouReallyWantToDeleteThisLog" = "Do you really want to delete this log?";
 "DoYouReallyWantToDeleteAllRecordedLogs" = "Do you really want to delete all recorded logs?";
+"AppSettings" = "App settings";