[PM-20538] Display toast on flight recorder log deletion (#1618)

Author: matt-livefront

BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings

@@ -1192,3 +1192,5 @@
 "NewTextSend" = "New text Send";
 "EditFileSend" = "Edit file Send";
 "EditTextSend" = "Edit text Send";
+"LogDeleted" = "Log deleted";
+"AllLogsDeleted" = "All logs deleted";

BitwardenShared/UI/Platform/Settings/Settings/About/FlightRecorderLogs/FlightRecorderLogsAction.swift

@@ -17,4 +17,7 @@ enum FlightRecorderLogsAction: Equatable {
 
     /// Share all flight recorder logs.
     case shareAll
+
+    /// The toast was shown or hidden.
+    case toastShown(Toast?)
 }

BitwardenShared/UI/Platform/Settings/Settings/About/FlightRecorderLogs/FlightRecorderLogsProcessor.swift

@@ -63,6 +63,8 @@ final class FlightRecorderLogsProcessor: StateProcessor<
         case .shareAll:
             let urls = state.logs.map(\.url)
             coordinator.navigate(to: .shareURLs(urls))
+        case let .toastShown(newValue):
+            state.toast = newValue
         }
     }
 
@@ -85,6 +87,7 @@ final class FlightRecorderLogsProcessor: StateProcessor<
         confirmDeletion(isBulkDeletion: true) {
             do {
                 try await self.services.flightRecorder.deleteInactiveLogs()
+                self.state.toast = Toast(title: Localizations.allLogsDeleted)
                 await self.loadData()
             } catch {
                 self.services.errorReporter.log(error: error)
@@ -99,6 +102,7 @@ final class FlightRecorderLogsProcessor: StateProcessor<
         confirmDeletion(isBulkDeletion: false) {
             do {
                 try await self.services.flightRecorder.deleteLog(log)
+                self.state.toast = Toast(title: Localizations.logDeleted)
                 await self.loadData()
             } catch {
                 self.services.errorReporter.log(error: error)

BitwardenShared/UI/Platform/Settings/Settings/About/FlightRecorderLogs/FlightRecorderLogsProcessorTests.swift

@@ -85,6 +85,7 @@ class FlightRecorderLogsProcessorTests: BitwardenTestCase {
 
         XCTAssertEqual(flightRecorder.deleteLogLogs, [log])
         XCTAssertTrue(flightRecorder.fetchLogsCalled)
+        XCTAssertEqual(subject.state.toast, Toast(title: Localizations.logDeleted))
     }
 
     /// `receive(_:)` with `.delete` logs an error and shows an error alert if an error occurs.
@@ -101,6 +102,7 @@ class FlightRecorderLogsProcessorTests: BitwardenTestCase {
 
         XCTAssertEqual(coordinator.errorAlertsShown as? [BitwardenTestError], [.example])
         XCTAssertEqual(errorReporter.errors as? [BitwardenTestError], [.example])
+        XCTAssertNil(subject.state.toast)
     }
 
     /// `receive(_:)` with `.deleteAll` shows a confirmation alert and then deletes the inactive logs.
@@ -118,6 +120,7 @@ class FlightRecorderLogsProcessorTests: BitwardenTestCase {
 
         XCTAssertTrue(flightRecorder.deleteInactiveLogsCalled)
         XCTAssertTrue(flightRecorder.fetchLogsCalled)
+        XCTAssertEqual(subject.state.toast, Toast(title: Localizations.allLogsDeleted))
     }
 
     /// `receive(_:)` with `.deleteAll` logs an error and shows an error alert if an error occurs.
@@ -134,6 +137,7 @@ class FlightRecorderLogsProcessorTests: BitwardenTestCase {
 
         XCTAssertEqual(coordinator.errorAlertsShown as? [BitwardenTestError], [.example])
         XCTAssertEqual(errorReporter.errors as? [BitwardenTestError], [.example])
+        XCTAssertNil(subject.state.toast)
     }
 
     /// `receive(_:)` with `.dismiss` dismisses the view.
@@ -169,4 +173,15 @@ class FlightRecorderLogsProcessorTests: BitwardenTestCase {
             ])
         )
     }
+
+    /// `receive(_:)` with `.toastShown` updates the state's toast value.
+    @MainActor
+    func test_receive_toastShown() {
+        let toast = Toast(title: "toast!")
+        subject.receive(.toastShown(toast))
+        XCTAssertEqual(subject.state.toast, toast)
+
+        subject.receive(.toastShown(nil))
+        XCTAssertNil(subject.state.toast)
+    }
 }

BitwardenShared/UI/Platform/Settings/Settings/About/FlightRecorderLogs/FlightRecorderLogsState.swift

@@ -8,6 +8,9 @@ struct FlightRecorderLogsState: Equatable {
     /// The list of flight recorder logs on the device.
     var logs = [FlightRecorderLogMetadata]()
 
+    /// A toast message to show in the view.
+    var toast: Toast?
+
     // MARK: Computed Properties
 
     /// Whether the delete all option is enabled.

BitwardenShared/UI/Platform/Settings/Settings/About/FlightRecorderLogs/FlightRecorderLogsView.swift

@@ -21,6 +21,10 @@ struct FlightRecorderLogsView: View {
         content
             .navigationBar(title: Localizations.recordedLogs, titleDisplayMode: .inline)
             .task { await store.perform(.loadData) }
+            .toast(store.binding(
+                get: \.toast,
+                send: FlightRecorderLogsAction.toastShown
+            ))
             .toolbar {
                 closeToolbarItem {
                     store.send(.dismiss)