[PM-20171] Fix ViewItemView retain cycle (#1581)

Author: andrebispo5

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemAction.swift

@@ -18,6 +18,9 @@ enum ViewItemAction: Equatable, Sendable {
     /// The visibility button was pressed for the specified custom field.
     case customFieldVisibilityPressed(CustomFieldState)
 
+    /// The view item disappeared from the screen.
+    case disappeared
+
     /// The dismiss button was pressed.
     case dismissPressed
 
@@ -57,7 +60,8 @@ enum ViewItemAction: Equatable, Sendable {
             true
         case let .copyPressed(_, field):
             field.requiresMasterPasswordReprompt
-        case .dismissPressed,
+        case .disappeared,
+             .dismissPressed,
              .passwordHistoryPressed,
              .toastShown:
             false

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemActionTests.swift

@@ -73,6 +73,7 @@ class ViewItemActionTests: BitwardenTestCase {
                 .requiresMasterPasswordReprompt
         )
 
+        XCTAssertFalse(ViewItemAction.disappeared.requiresMasterPasswordReprompt)
         XCTAssertFalse(ViewItemAction.dismissPressed.requiresMasterPasswordReprompt)
 
         XCTAssertTrue(ViewItemAction.downloadAttachment(.fixture()).requiresMasterPasswordReprompt)

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift

@@ -57,6 +57,9 @@ final class ViewItemProcessor: StateProcessor<ViewItemState, ViewItemAction, Vie
     /// The services used by this processor.
     private let services: Services
 
+    /// The task that streams cipher details.
+    private(set) var streamCipherDetailsTask: Task<Void, Never>?
+
     // MARK: Initialization
 
     /// Creates a new `ViewItemProcessor`.
@@ -95,7 +98,10 @@ final class ViewItemProcessor: StateProcessor<ViewItemState, ViewItemAction, Vie
     override func perform(_ effect: ViewItemEffect) async {
         switch effect {
         case .appeared:
-            await streamCipherDetails()
+            streamCipherDetailsTask?.cancel()
+            streamCipherDetailsTask = Task {
+                await streamCipherDetails()
+            }
         case .checkPasswordPressed:
             do {
                 guard let password = state.loadingState.data?.cipher.login?.password else { return }
@@ -155,6 +161,9 @@ final class ViewItemProcessor: StateProcessor<ViewItemState, ViewItemAction, Vie
                     )
                 }
             }
+        case .disappeared:
+            streamCipherDetailsTask?.cancel()
+            streamCipherDetailsTask = nil
         case .dismissPressed:
             coordinator.navigate(to: .dismiss())
         case let .downloadAttachment(attachment):

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessorTests.swift

@@ -157,6 +157,7 @@ class ViewItemProcessorTests: BitwardenTestCase { // swiftlint:disable:this type
         )
         vaultRepository.cipherDetailsSubject.send(cipherItem)
 
+        XCTAssertNil(subject.streamCipherDetailsTask)
         let task = Task {
             await subject.perform(.appeared)
         }
@@ -172,6 +173,7 @@ class ViewItemProcessorTests: BitwardenTestCase { // swiftlint:disable:this type
 
         expectedState.allUserCollections = collections
 
+        XCTAssertNotNil(subject.streamCipherDetailsTask)
         XCTAssertTrue(subject.state.hasPremiumFeatures)
         XCTAssertTrue(subject.state.hasMasterPassword)
         XCTAssertFalse(subject.state.restrictCipherItemDeletionFlagEnabled)
@@ -781,6 +783,25 @@ class ViewItemProcessorTests: BitwardenTestCase { // swiftlint:disable:this type
         XCTAssertEqual(coordinator.routes.last, .dismiss())
     }
 
+    /// `receive` with `.disappeared` should clear streamCipherDetailsTask.
+    @MainActor
+    func test_receive_disappearPressed() {
+        let account = Account.fixture()
+        stateService.activeAccount = account
+
+        XCTAssertNil(subject.streamCipherDetailsTask)
+        let task = Task {
+            await subject.perform(.appeared)
+        }
+
+        waitFor(subject.state.loadingState != .loading(nil))
+        task.cancel()
+
+        XCTAssertNotNil(subject.streamCipherDetailsTask)
+        subject.receive(.disappeared)
+        XCTAssertNil(subject.streamCipherDetailsTask)
+    }
+
     /// `perform(_:)` with `.deletePressed` presents the confirmation alert before delete the item and displays
     /// generic error alert if soft deleting fails.
     @MainActor

BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemView.swift

@@ -107,6 +107,9 @@ struct ViewItemView: View {
                 await store.perform(.appeared)
             }
         }
+        .onDisappear {
+            store.send(.disappeared)
+        }
     }
 
     // MARK: Private Views