[PM-21128] Hide the maximum access count info for View Send (#1630)

Author: matt-livefront

BitwardenShared/UI/Tools/Send/SendItem/AddEditSendItem/SendItemAccessCountStepper.swift

@@ -10,6 +10,9 @@ struct SendItemAccessCountStepper: View {
     /// The number of times the send has been accessed.
     let currentAccessCount: Int?
 
+    /// Whether the maximum access count info text should be displayed in the footer.
+    let displayInfoText: Bool
+
     /// A binding for changing the maximum access account for the send in the stepper.
     @Binding var maximumAccessCount: Int
 
@@ -28,9 +31,11 @@ struct SendItemAccessCountStepper: View {
                     .foregroundStyle(Asset.Colors.textPrimary.swiftUIColor)
             } footer: {
                 VStack(alignment: .leading, spacing: 2) {
-                    Text(Localizations.maximumAccessCountInfo)
-                        .styleGuide(.footnote)
-                        .foregroundColor(Asset.Colors.textSecondary.swiftUIColor)
+                    if displayInfoText {
+                        Text(Localizations.maximumAccessCountInfo)
+                            .styleGuide(.footnote)
+                            .foregroundColor(Asset.Colors.textSecondary.swiftUIColor)
+                    }
 
                     if let currentAccessCount {
                         // Wrap these texts in a group so that the style guide can be set on
@@ -48,6 +53,21 @@ struct SendItemAccessCountStepper: View {
             .accessibilityIdentifier("SendMaxAccessCountEntry")
         }
     }
+
+    // MARK: Initialization
+
+    /// Initialize a `SendItemAccessCountStepper`.
+    ///
+    /// - Parameters:
+    ///   - currentAccessCount: The number of times the send has been accessed.
+    ///   - displayInfoText: Whether the maximum access count info text should be displayed in the footer.
+    ///   - maximumAccessCount: A binding for changing the maximum access account for the send in the stepper.
+    ///
+    init(currentAccessCount: Int?, displayInfoText: Bool = true, maximumAccessCount: Binding<Int>) {
+        self.currentAccessCount = currentAccessCount
+        self.displayInfoText = displayInfoText
+        _maximumAccessCount = maximumAccessCount
+    }
 }
 
 // MARK: - Previews

BitwardenShared/UI/Tools/Send/SendItem/ViewSendItem/ViewSendItemView.swift

@@ -61,6 +61,7 @@ struct ViewSendItemView: View {
             deleteSendButton
         }
         .animation(.default, value: store.state.isAdditionalOptionsExpanded)
+        .padding(.bottom, FloatingActionButton.bottomOffsetPadding)
     }
 
     /// The expandable additional options section.
@@ -77,6 +78,7 @@ struct ViewSendItemView: View {
                 if let maxAccessCount = store.state.sendView.maxAccessCount {
                     SendItemAccessCountStepper(
                         currentAccessCount: Int(store.state.sendView.accessCount),
+                        displayInfoText: false,
                         maximumAccessCount: .constant(Int(maxAccessCount))
                     )
                     .disabled(true)

BitwardenShared/UI/Tools/Send/SendItem/ViewSendItem/ViewSendItemViewTests.swift

@@ -100,6 +100,7 @@ class ViewSendItemViewTests: BitwardenTestCase {
                 name: "My text send",
                 notes: "Private notes for the send",
                 text: .fixture(text: "Some text to send"),
+                maxAccessCount: 3,
             ),
             shareURL: URL(string: "send.bitwarden.com/39ngaol3")
         )