[PM-18262] feat: Implemented SimpleLogin Self-host server URL #1501
+77
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er url and fix issue of its default base url that was causing the service not to work.
This was
linked to
issues
Apr 15, 2025
|
Great job, no security vulnerabilities found in this Pull Request |
matt-livefront
previously approved these changes
Apr 15, 2025
fedemkr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 89.64% 89.65%
=======================================
Files 780 780
Lines 48785 48804 +19
=======================================
+ Hits 43733 43754 +21
+ Misses 5052 5050 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matt-livefront
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-18262
📔 Objective
Add support for SimpleLogin Self-host server URL.
This also fixes an issue for SimpleLogin where the default URL to use for the service was not being passed and that's why the generation wasn't working.
📸 Screenshots
SimpleLogin Self-host
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes