Skip to content

[PM-11598] fix: GitHub Release v2 #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 29, 2024
Merged

[PM-11598] fix: GitHub Release v2 #1175

merged 15 commits into from
Nov 29, 2024

Conversation

vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Nov 27, 2024

🎟️ Tracking

PM-11598

📔 Objective

Started as a fix for iOS artifacts upload, ended up as bigger revamp of the GitHub Release creation workflow. Improvements:

  1. Gets Version info from run artifacts
  2. Replaced third-party action with GH CLI
  3. Automated notes now handle tags in unconnected branches (ie, release branches with cherry picks 🍒 ⛏️ )
  4. Run artifacts are now zipped and properly uploaded
  5. 🍥 Logs

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Logo
Checkmarx One – Scan Summary & Details440fa3e1-db12-4586-9894-44faa9e6b533

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /crowdin-push.yml: 26

@vvolkgang vvolkgang force-pushed the fix-github-release branch 2 times, most recently from 06f16ae to dac362d Compare November 27, 2024 23:02
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (8293f41) to head (55baa3d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   89.39%   89.47%   +0.08%     
==========================================
  Files         688      688              
  Lines       43798    43806       +8     
==========================================
+ Hits        39152    39197      +45     
+ Misses       4646     4609      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang force-pushed the fix-github-release branch 2 times, most recently from 72dd75e to f6e1b5a Compare November 27, 2024 23:56
@vvolkgang vvolkgang changed the title [PM-11598] fix: zips artifacts downloaded from action run [PM-11598] fix: GitHub Release v2 Nov 28, 2024
@vvolkgang vvolkgang merged commit 7000381 into main Nov 29, 2024
10 checks passed
@vvolkgang vvolkgang deleted the fix-github-release branch November 29, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants