[PM-19644] Remove two factor notice. #1502
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
- Coverage 89.66% 85.78% -3.89%
==========================================
Files 781 982 +201
Lines 48834 58618 +9784
==========================================
+ Hits 43788 50283 +6495
- Misses 5046 8335 +3289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
| @@ -1184,10 +1165,6 @@ extension DefaultAppSettingsStore: AppSettingsStore { | |||
| store(key, for: .vaultTimeoutAction(userId: userId)) | |||
| } | |||
|
|
|||
| func setTwoFactorNoticeDisplayState(_ state: TwoFactorNoticeDisplayState, userId: String) { | |||
| store(state, for: .twoFactorNoticeDisplayState(userId: userId)) | |||
There was a problem hiding this comment.
🤔 Do we care about leaving this state sitting in UserDefaults when it's no longer accessible? Or should we find a way to clean it up?
There was a problem hiding this comment.
I thought about it, but it's a very small piece of data, compared to having to check the UserDefaults every time the app launches to remove it if exists, I think it's preferable to leave it be (there is a big chance that it was never saved in the first place).
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19644
📔 Objective
Remove two factor notice screens and feature flags.
Remove state values.
Remove related resources.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes