Skip to content

Update memory-testing Dockerfile to use cargo-chef #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented May 1, 2025

🎟️ Tracking

📔 Objective

The previous Dockerfile was trying to copy only the Cargo.toml and creating fake lib.rs files in an attempt to build the dependencies before the rest of the source code was copied, which would help with build caching and improve build times considerably. This was very error prone and would break any time extra workspace dependencies were added.

This PR migrates that process to use cargo-chef instead, which automatically handles that process for us. The dependencies get cached just as well as before, but we don't need to fiddle with creating fake lib.rs to make the compiler happy.

I've also updated the dockerignore to include some files that were previously missing.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dani-garcia dani-garcia requested a review from a team as a code owner May 1, 2025 21:20
@dani-garcia dani-garcia requested a review from addisonbeck May 1, 2025 21:20
Copy link
Contributor

github-actions bot commented May 1, 2025

Logo
Checkmarx One – Scan Summary & Details322a4913-a351-4739-b0f2-0d8dc8e3b30e

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (90c331a) to head (de75426).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files         213      213           
  Lines       16644    16644           
=======================================
  Hits        11578    11578           
  Misses       5066     5066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant