Skip to content

Commit e5c6294

Browse files
committed
[PM-15621] Update the remaining names to 'claimed'.
1 parent c89feec commit e5c6294

File tree

3 files changed

+11
-23
lines changed

3 files changed

+11
-23
lines changed

src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteClaimedOrganizationUserAccountCommand.cs

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@ public class DeleteClaimedOrganizationUserAccountCommand : IDeleteClaimedOrganiz
2525
private readonly IUserService _userService;
2626
private readonly IEventService _eventService;
2727
private readonly IGetOrganizationUsersClaimedStatusQuery _getOrganizationUsersClaimedStatusQuery;
28-
private readonly IDeleteClaimedOrganizationUserAccountValidator _deleteManagedOrganizationUserAccountValidator;
28+
private readonly IDeleteClaimedOrganizationUserAccountValidator _deleteClaimedOrganizationUserAccountValidator;
2929
private readonly ILogger<DeleteClaimedOrganizationUserAccountCommand> _logger;
3030
private readonly IOrganizationUserRepository _organizationUserRepository;
3131
private readonly IUserRepository _userRepository;
3232
private readonly ICurrentContext _currentContext;
3333
private readonly IReferenceEventService _referenceEventService;
3434
private readonly IPushNotificationService _pushService;
35-
private readonly IProviderUserRepository _providerUserRepository;
3635
public DeleteClaimedOrganizationUserAccountCommand(
3736
IUserService userService,
3837
IEventService eventService,
@@ -44,7 +43,7 @@ public DeleteClaimedOrganizationUserAccountCommand(
4443
IPushNotificationService pushService,
4544
IProviderUserRepository providerUserRepository,
4645
ILogger<DeleteClaimedOrganizationUserAccountCommand> logger,
47-
IDeleteClaimedOrganizationUserAccountValidator deleteManagedOrganizationUserAccountValidator)
46+
IDeleteClaimedOrganizationUserAccountValidator deleteClaimedOrganizationUserAccountValidator)
4847
{
4948
_userService = userService;
5049
_eventService = eventService;
@@ -54,9 +53,8 @@ public DeleteClaimedOrganizationUserAccountCommand(
5453
_currentContext = currentContext;
5554
_referenceEventService = referenceEventService;
5655
_pushService = pushService;
57-
_providerUserRepository = providerUserRepository;
5856
_logger = logger;
59-
_deleteManagedOrganizationUserAccountValidator = deleteManagedOrganizationUserAccountValidator;
57+
_deleteClaimedOrganizationUserAccountValidator = deleteClaimedOrganizationUserAccountValidator;
6058
}
6159

6260
public async Task<CommandResult<DeleteUserResponse>> DeleteUserAsync(Guid organizationId, Guid organizationUserId, Guid deletingUserId)
@@ -94,10 +92,10 @@ private async Task<PartialValidationResult<DeleteUserValidationRequest>> Interna
9492
{
9593
var orgUsers = await _organizationUserRepository.GetManyAsync(orgUserIds);
9694
var users = await GetUsersAsync(orgUsers);
97-
var managementStatuses = await _getOrganizationUsersClaimedStatusQuery.GetUsersOrganizationClaimedStatusAsync(organizationId, orgUserIds);
95+
var claimedStatuses = await _getOrganizationUsersClaimedStatusQuery.GetUsersOrganizationClaimedStatusAsync(organizationId, orgUserIds);
9896

99-
var requests = CreateRequests(organizationId, deletingUserId, orgUserIds, orgUsers, users, managementStatuses);
100-
var results = await _deleteManagedOrganizationUserAccountValidator.ValidateAsync(requests);
97+
var requests = CreateRequests(organizationId, deletingUserId, orgUserIds, orgUsers, users, claimedStatuses);
98+
var results = await _deleteClaimedOrganizationUserAccountValidator.ValidateAsync(requests);
10199

102100
await CancelPremiumsAsync(results.ValidResults);
103101
await HandleUserDeletionsAsync(results.ValidResults);
@@ -112,37 +110,27 @@ private List<DeleteUserValidationRequest> CreateRequests(
112110
IEnumerable<Guid> orgUserIds,
113111
ICollection<OrganizationUser> orgUsers,
114112
IEnumerable<User> users,
115-
IDictionary<Guid, bool> managementStatuses)
113+
IDictionary<Guid, bool> claimedStatuses)
116114
{
117115
var requests = new List<DeleteUserValidationRequest>();
118116
foreach (var orgUserId in orgUserIds)
119117
{
120118
var orgUser = orgUsers.FirstOrDefault(orgUser => orgUser.Id == orgUserId);
121119
var user = users.FirstOrDefault(user => user.Id == orgUser?.UserId);
122-
managementStatuses.TryGetValue(orgUserId, out var isManaged);
120+
claimedStatuses.TryGetValue(orgUserId, out var isClaimed);
123121

124122
requests.Add(new DeleteUserValidationRequest
125123
{
126124
User = user,
127125
OrganizationUserId = orgUserId,
128126
OrganizationUser = orgUser,
129-
IsManaged = isManaged,
127+
IsClaimed = isClaimed,
130128
OrganizationId = organizationId,
131129
DeletingUserId = deletingUserId,
132130
});
133131
}
134132

135133
return requests;
136-
// Jimmy move this to the validator
137-
// if (orgUser.Type == OrganizationUserType.Admin && await _currentContext.OrganizationCustom(organizationId))
138-
// {
139-
// throw new BadRequestException("Custom users can not delete admins.");
140-
// }
141-
142-
// if (!claimedStatus.TryGetValue(orgUser.Id, out var isClaimed) || !isClaimed)
143-
// {
144-
// throw new BadRequestException("Member is not claimed by the organization.");
145-
// }
146134
}
147135

148136
private async Task<IEnumerable<User>> GetUsersAsync(ICollection<OrganizationUser> orgUsers)

src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteClaimedOrganizationUserAccountValidator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ private static ValidationResult<DeleteUserValidationRequest> EnsureUserBelongsTo
9797

9898
private static ValidationResult<DeleteUserValidationRequest> EnsureUserIsManagedByOrganization(DeleteUserValidationRequest request)
9999
{
100-
if (request.IsManaged == true)
100+
if (request.IsClaimed == true)
101101
{
102102
return new Valid<DeleteUserValidationRequest>();
103103
}

src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/DeleteUserValidationRequest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ public class DeleteUserValidationRequest
1010
public OrganizationUser? OrganizationUser { get; init; }
1111
public User? User { get; init; }
1212
public Guid DeletingUserId { get; init; }
13-
public bool? IsManaged { get; init; }
13+
public bool? IsClaimed { get; init; }
1414
}

0 commit comments

Comments
 (0)