Skip to content

[PM-13748] Remove SCIM provider type checks from group endpoints #5231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 13, 2025

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Jan 8, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13748

📔 Objective

Remove the scimContext.RequestScimProvider checks (and early return) at the top of the following methods in the SCIM project:

PostGroupCommand.UpdateGroupMembersAsync

PutGroupCommand.UpdateGroupMembersAsync

This will allow these methods (and corresponding endpoints) to be used by any SCIM provider which will resolve the initial report.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome requested a review from eliykat January 8, 2025 15:42
@r-tome r-tome marked this pull request as ready for review January 8, 2025 15:42
@r-tome r-tome requested a review from a team as a code owner January 8, 2025 15:42
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.43%. Comparing base (5d3294c) to head (20cf96b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5231      +/-   ##
==========================================
- Coverage   44.43%   44.43%   -0.01%     
==========================================
  Files        1500     1500              
  Lines       69545    69533      -12     
  Branches     6262     6260       -2     
==========================================
- Hits        30905    30899       -6     
+ Misses      37313    37309       -4     
+ Partials     1327     1325       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Detailsa7ac135a-0c10-440d-9f65-81ac13130a20

Great job, no security vulnerabilities found in this Pull Request

@eliykat eliykat linked an issue Jan 10, 2025 that may be closed by this pull request
1 task
@r-tome r-tome removed the needs-qa label Feb 13, 2025
@r-tome r-tome merged commit 459c91a into main Feb 13, 2025
53 checks passed
@r-tome r-tome deleted the ac/pm-13748/unblock-group-endpoints branch February 13, 2025 10:30
r-tome added a commit that referenced this pull request Feb 19, 2025
* [PM-13748] Remove SCIM provider type checks from group endpoints

* Remove Okta provider type config from group command tests

---------

Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCIM Group POST and PUT member changes are hardcoded to only support Okta
3 participants