Skip to content

[PM-17014] Fix delete action for cs/billing | add RequestDelete permission #5258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

vincentsalucci
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17014

📔 Objective

Giving CS/Billing the Org_Delete permission had unintended side-effects of extending them the ability to request delete AND delete an organization.

  • Removed Org_Delete permission for CS and Billing roles
  • Created new Org_RequestDelete permission and added it to Owners, Admins, CS, and Billing roles

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vincentsalucci vincentsalucci self-assigned this Jan 13, 2025
@vincentsalucci vincentsalucci requested a review from a team as a code owner January 13, 2025 19:23
@vincentsalucci vincentsalucci requested a review from r-tome January 13, 2025 19:23
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.99%. Comparing base (72bb06a) to head (9cd7b4e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...Admin/AdminConsole/Views/Organizations/Edit.cshtml 0.00% 5 Missing ⚠️
src/Admin/Utilities/RolePermissionMapping.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5258      +/-   ##
==========================================
- Coverage   44.00%   43.99%   -0.01%     
==========================================
  Files        1476     1476              
  Lines       68300    68306       +6     
  Branches     6173     6175       +2     
==========================================
  Hits        30053    30053              
- Misses      36939    36945       +6     
  Partials     1308     1308              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsca86333b-8460-4034-9a08-3f7f1dfafb4d

Great job, no security vulnerabilities found in this Pull Request

@vincentsalucci vincentsalucci merged commit 82508fb into main Jan 13, 2025
55 checks passed
@vincentsalucci vincentsalucci deleted the ac/pm-17014/admin-portal-request-delete branch January 13, 2025 20:54
vincentsalucci added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants