Skip to content

[PM-15127][TEST] Remove secrets requirement from build workflow #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dani-garcia
Copy link
Member

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@S-Kakar
Copy link

S-Kakar commented Mar 24, 2025

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-19463
Link: https://bitwarden.atlassian.net/browse/PM-19463

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@S-Kakar S-Kakar changed the title [PM-15127][TEST] Remove secrets requirement from build workflow [PM-19463] [PM-15127][TEST] Remove secrets requirement from build workflow Mar 24, 2025
@dani-garcia dani-garcia changed the title [PM-19463] [PM-15127][TEST] Remove secrets requirement from build workflow [PM-15127][TEST] Remove secrets requirement from build workflow Mar 24, 2025
Copy link
Contributor

github-actions bot commented Mar 24, 2025

Logo
Checkmarx One – Scan Summary & Details83036741-13a6-4a54-bae2-e17a34c8e01f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.54%. Comparing base (d345937) to head (879974b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5548   +/-   ##
=======================================
  Coverage   44.54%   44.54%           
=======================================
  Files        1543     1543           
  Lines       70761    70761           
  Branches     6333     6333           
=======================================
  Hits        31519    31519           
  Misses      37889    37889           
  Partials     1353     1353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia dani-garcia force-pushed the ps/PM-15127-tighten-scope-secrets-test branch from 0638adf to b05b707 Compare March 24, 2025 15:17
@dani-garcia dani-garcia deleted the ps/PM-15127-tighten-scope-secrets-test branch March 24, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants