Skip to content

PM-20112 Created custom query to improve performance for Member Access Report #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

prograhamming
Copy link
Contributor

@prograhamming prograhamming commented May 28, 2025

🎟️ Tracking

PM-20112

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@prograhamming prograhamming requested a review from a team as a code owner May 28, 2025 14:30
Copy link
Contributor

github-actions bot commented May 28, 2025

Logo
Checkmarx One – Scan Summary & Detailsc645a2bf-b53a-40a8-99a9-6fab9e3fd289

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
detailsMethod Post at line 143 of /src/Api/Controllers/CollectionsController.cs gets a parameter from a user request from orgId. This parameter value fl...
ID: W5s%2FSNe54CPP1CxzYuVqrn9v0%2Fk%3D
Attack Vector
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 135
detailsMethod Post at line 135 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from orgId. This parameter ...
ID: Qs417oLwYMuJ1g8cUCMHpbUJ9d0%3D
Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/Layouts/Full.html.hbs: 164
detailsA Content Security Policy is not explicitly defined within the web-application.
ID: iDkz8rv3w1QoR%2BKANf%2FBdTS52Xc%3D
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 52
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 201

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 51.14%. Comparing base (769313a) to head (c082c91).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...Dapper/Dirt/MemberAccessCipherDetailsRepository.cs 0.00% 18 Missing ⚠️
...mework/Dirt/MemberAccessCipherDetailsRepository.cs 0.00% 14 Missing ⚠️
...s/ReportFeatures/MemberAccessCipherDetailsQuery.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5887      +/-   ##
==========================================
+ Coverage   47.74%   51.14%   +3.40%     
==========================================
  Files        1665     1667       +2     
  Lines       75015    74904     -111     
  Branches     6755     6743      -12     
==========================================
+ Hits        35814    38308    +2494     
+ Misses      37741    35077    -2664     
- Partials     1460     1519      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prograhamming prograhamming requested a review from a team as a code owner June 4, 2025 19:23
Copy link

sonarqubecloud bot commented Jun 4, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@prograhamming prograhamming changed the title PM-20112 limiting threads for member access query method PM-20112 Created custom query to improve performance for Member Access Report Jun 4, 2025
Copy link

sonarqubecloud bot commented Jun 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants