[PM-22344] - fix Error: Cannot Decrypt when moving a vault item to a collection #5911
+46
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaasen-livefront
changed the title
gbubemismith
previously approved these changes
Jun 3, 2025
|
@jaasen-livefront Switching to a |
shane-melton
requested changes
Jun 3, 2025
|
Great job, no security vulnerabilities found in this Pull Request |
gbubemismith
approved these changes
Jun 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5911 +/- ##
==========================================
+ Coverage 47.73% 47.74% +0.01%
==========================================
Files 1665 1665
Lines 75014 75015 +1
Branches 6755 6755
==========================================
+ Hits 35806 35814 +8
+ Misses 37743 37741 -2
+ Partials 1465 1460 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gbubemismith
requested changes
Jun 3, 2025
| @@ -1106,7 +1106,8 @@ public async Task<CipherMiniResponseModel[]> PutShareMany([FromBody] CipherBulkS | |||
| userId | |||
| ); | |||
|
|
|||
| return updated.Select(c => new CipherMiniResponseModel(c, _globalSettings, false)).ToArray(); | |||
| var response = updated.Select(c => new CipherMiniResponseModel(c, _globalSettings, false)).ToArray(); | |||
There was a problem hiding this comment.
We don't need the toArray anymore
gbubemismith
previously approved these changes
Jun 3, 2025
shane-melton
reviewed
Jun 3, 2025
|
shane-melton
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22344
📔 Objective
This PR fixes an issue where the
/cipher/shareendpoint was causing the shared cipher's encryption to break. This was due to a change from this PR that changed usingToCipherto casting withCipherwhich caused a loss of the associated data and thus a failure of decryption in the client. It also returns as aListResponseModeland updates the tests.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes