Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze with TASK and inline footnotes #2521

Open
NekoiNemo opened this issue Feb 8, 2025 · 5 comments
Open

Freeze with TASK and inline footnotes #2521

NekoiNemo opened this issue Feb 8, 2025 · 5 comments
Assignees
Labels
bug Something isn't working.

Comments

@NekoiNemo
Copy link

NekoiNemo commented Feb 8, 2025

What happened?

When a task that has an inline footnote ^[this kind] is present in the search path (excluding them in FROM bypasses the issue) of the TASK query - it causes the entirety of Obsidian to freeze up when the note with the query is loaded in Reading mode.

Easy reproducible example would be to create a test note with following content:

- [ ] foo ^[bar]

DQL

TASK
FROM "test.md"

JS

Dataview Version

0.5.67

Obsidian Version

1.8.4

OS

Linux

@NekoiNemo NekoiNemo added the bug Something isn't working. label Feb 8, 2025
@NekoiNemo
Copy link
Author

Closing as there seem to be something else causing DataView to freeze, not the markers

@NekoiNemo NekoiNemo changed the title Freeze with custom task markers Freeze wit TASK and inline footnotes Feb 8, 2025
@NekoiNemo NekoiNemo reopened this Feb 8, 2025
@NekoiNemo
Copy link
Author

Nailed it down to an inline footnote instead (as, turns out, in my vault, the exact files that had custom tasks also had inline footnotes, what are the odds?)

@NekoiNemo NekoiNemo changed the title Freeze wit TASK and inline footnotes Freeze with TASK and inline footnotes Feb 8, 2025
@NekoiNemo
Copy link
Author

As a side note/bug: having a regular footnote on a task item causes its label to be rendered as plain text in the TASK results, e.g. Foo[^bar] gets rendered as Foobar in the query result

@holroy
Copy link
Collaborator

holroy commented Feb 25, 2025

So exactly what is the current bug situation as you see it? What triggers it, and what do you expect to happen, which doesn't happen? I'm a little confused at all the back and forth...

@NekoiNemo
Copy link
Author

Hi!

I apologise about the excessive messages, as i initially misdiagnosed the issue, closed it, and then reopened when i had a more concrete example.

So, i ran a few more tests, and there seem to be some conflict between the DataView and Fancy a Story theme, specifically when it comes to showing inline footnotes on tasks with the TASK query. I'm not exactly sure what causes it, since there are no problems with the query without the theme applied, nor with theme displaying them in DV-less environment.

However, there are a few bug/issues in the way DataView displays the footnotes that might be the cause:

Image

  • As you can see, the [1] link on the second task got replaced with jsut an undecorated "1" appended to the task. Which is a bit of an issue with presentation (i feel like it should be stripped if a footnote can't be displayed properly otherwise), though not critical and i doubt it is the one causing the freeze
  • The inline footnote is displayed properly at a glance (it is shown at the bottom of the page and both it and the footnote indicator both have correct numbers), but upon hovering it shows the message on the screenshot, with an error about improperly linked footnote, and with an odd name. I believe this might be the cause of the issue.

You can reproduce it by installing the aforementioned FaS theme and DV plugin in a sandbox vault and adding the following to the note:

- [ ] foo^[bar]

```dataview
TASK
```

@holroy holroy self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants