-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instantiate Per Codeblock Refresh Disabling #2402
base: master
Are you sure you want to change the base?
Conversation
I think this is a great solution but disable-refresh is somewhat generic tag and so it has a nonzero potential for accidental enabling. Have you considered calling it something like "dataview-disable-refresh"? |
@reply2za For sure, in the original bug ticket my initial thought was to make it similar to typescripts ignore, so potentially changing this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation and code text refers to two different strings to disable the refresh. In addition the text seems to be looked for everywhere in the script, not only in comment sections.
When looking into Code block parameters, an option related to changing/disable the refresh of any given query will be looked into. |
This will be dealt with in 0.6.x, as part of the changes related to code block parameters. That will also address the issue of the non-anchored text issue. As such this PR will not be merged as is.
Simple solution and only applicable to
dataviewjs
.Allows for a comment within the codeblock—
disable-refresh
—to disable automatic refreshing for selectdataviewjs
queries. Thus, preventing flashing of rendered diagrams yet still allowing the functionality of automatic view refreshing.Example:
Fixes: #2396