-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Cleanup + Optimizations #1944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d701d1
to
ab18378
Compare
9925506
to
398ec87
Compare
@CascadingRadium let's have you walk the team through this real quick on tomorrow's call. We can move ahead with review and merging after. |
398ec87
to
c354da8
Compare
abhinavdangeti
requested changes
Jan 4, 2024
abhinavdangeti
approved these changes
Jan 4, 2024
abhinavdangeti
requested changes
Jan 4, 2024
f9b221d
to
5f2ecbc
Compare
abhinavdangeti
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of Optimization
Dataset - SIFT 1 Million dataset
Index - 1 partition index
Before this commit - Query Execution time - 2.25 seconds
With this commit - Query Execution time - 1.70 seconds
Percentage Reduction - 24.4%