Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup + Optimizations #1944

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Code Cleanup + Optimizations #1944

merged 7 commits into from
Jan 5, 2024

Conversation

CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Dec 19, 2023

  • Cleanup up unused code paths since the merging of MB-59102: Merging kNN hits from a distributed index with exact search hits #1936 changed the overall approach, resulting in a lot of dead code.
  • Optimized the KNN collector to not update the allHits map for every hit and instead just use its internal heaps when the Final() is called.
  • Typo Fix
  • Optimized the OptimizeVR's Finish() method to concurrently search across segments.

Results of Optimization

Dataset - SIFT 1 Million dataset
Index - 1 partition index

Before this commit - Query Execution time - 2.25 seconds
With this commit - Query Execution time - 1.70 seconds
Percentage Reduction - 24.4%

@CascadingRadium CascadingRadium self-assigned this Dec 19, 2023
@CascadingRadium CascadingRadium changed the title Code cleanup + Optimizations Score explanation to reflect the correct data in Hybrid Search Dec 21, 2023
@CascadingRadium CascadingRadium changed the title Score explanation to reflect the correct data in Hybrid Search Code Cleanup + Optimizations Dec 21, 2023
@CascadingRadium CascadingRadium force-pushed the knn-optimization branch 2 times, most recently from 9925506 to 398ec87 Compare December 22, 2023 11:22
@abhinavdangeti
Copy link
Member

@CascadingRadium let's have you walk the team through this real quick on tomorrow's call. We can move ahead with review and merging after.

@abhinavdangeti abhinavdangeti merged commit 58e76ce into unstable Jan 5, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the knn-optimization branch January 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants