Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-60274: Set an upper bound for K value for KNN queries #1953

Merged
merged 1 commit into from
Jan 5, 2024
Merged

MB-60274: Set an upper bound for K value for KNN queries #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions search_knn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import (

type knnOperator string

const MaxKValue = 10000

type SearchRequest struct {
Query query.Query `json:"query"`
Size int `json:"size"`
Expand Down Expand Up @@ -230,6 +232,9 @@ func validateKNN(req *SearchRequest) error {
if q.K <= 0 || len(q.Vector) == 0 {
return fmt.Errorf("k must be greater than 0 and vector must be non-empty")
}
if q.K > MaxKValue {
return fmt.Errorf("k must be less than %d", MaxKValue)
}
}
switch req.KNNOperator {
case knnOperatorAnd, knnOperatorOr, "":
Expand Down
Loading