Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search cost unit test #2019

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix search cost unit test #2019

merged 2 commits into from
Apr 22, 2024

Conversation

CascadingRadium
Copy link
Member

@CascadingRadium CascadingRadium commented Apr 22, 2024

  • Fix the BytesRead and BytesStored unit tests to pass when using the vectors tag. The following commands can be used to validate that all UTs now pass.
    • go test -tags=vectors -race ./...
    • go test -race ./...

@CascadingRadium CascadingRadium marked this pull request as draft April 22, 2024 17:18
@CascadingRadium CascadingRadium marked this pull request as ready for review April 22, 2024 17:41
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recommendation here is we simply drop these cost checks or the entire unit tests even and not over-engineer anything here.

Numbers such as 21639 or whatever don't mean anything in the tests's context.

@CascadingRadium
Copy link
Member Author

the test has been failing for many months now ...
mainly its because the SectionVectorIndex is locked under the
vectors build tag so without the tag only 1 section is there

i am not sure if there is a better way to validate the cost
other than a hard coded value...

@CascadingRadium CascadingRadium changed the title Vector Search Feature Flag Fix search cost unit test Apr 22, 2024
@abhinavdangeti abhinavdangeti merged commit b344994 into master Apr 22, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the fixUT2 branch April 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants