MB-61985: Add a Scorch event for Index() #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CascadingRadium
commented
Jul 18, 2024
•
CascadingRadium
commented
- Add a scorch event for notifying listeners, if available, that a document is about to get added to the index, using the Index() API.
- This event can be useful for halting indexing before the Index() operation is carried out - since Index() converts an interface into a Document object using the IndexMapping's MapDocument, which consumes some extra memory.
- Shifted the EventKindBatchIntroductionStart event to before the documents were analyzed as document analysis consumes extra memory.
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
abhinavdangeti
requested changes
Jul 18, 2024
CascadingRadium
changed the title
CascadingRadium
force-pushed
the
appHerder
branch
2 times, most recently
from
b7ed6e0 to
2ac9741
Compare
abhinavdangeti
force-pushed
the
appHerder
branch
from
87d3fe9 to
baa09d9
Compare
abhinavdangeti
previously approved these changes
Aug 5, 2024
Thejas-bhat
reviewed
Aug 6, 2024
CascadingRadium
force-pushed
the
appHerder
branch
from
baa09d9 to
80dfac6
Compare
abhinavdangeti
approved these changes
Aug 6, 2024
ns-codereview
pushed a commit
to couchbase/cbft
that referenced
this pull request
Aug 7, 2024
- Utilize the Scorch event, EventKindIndexStart, to pause document ingestion by DCP agents until memory pressure is reduced. - Fix a possible timer leak by using a `time.NewTicker` instead of `time.Tick` - Brings in blevesearch/bleve#2054 Change-Id: Id51c15b80c334d9001e6fccd4e4256ffe4979f04 Reviewed-on: https://review.couchbase.org/c/cbft/+/212958 Well-Formed: Restriction Checker Well-Formed: Build Bot <build@couchbase.com> Tested-by: Rahul Rampure <rahul.rampure@couchbase.com> Reviewed-by: Abhi Dangeti <abhinav@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.