MB-62400: Allow vector and numeric aliases for the same field #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Likith101
commented
Jul 23, 2024
Likith101
commented
- Removed logic that prevents numeric field mappings to be executed after a vector field has been detected
- Added checks to walk document on non vector field types preserving previous logic
- Removed logic that prevents numeric field mappings to be executed after a vector field has been detected - Added checks to walk document on non vector field types preserving previous logic
Likith101
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
moshaad7
CascadingRadium
approved these changes
Jul 23, 2024
| isPropertyVectorInitialized = true | ||
| } else { | ||
| isPropertyVector = isPropertyVector && processed | ||
| } |
There was a problem hiding this comment.
@Likith101 I believe @CascadingRadium added this and my memory on this is somewhat hazy - it seems we did this to avoid having to process a vector field multiple times, I like your code proposal here which is simple and easy to follow - just want to make sure we're not inadvertently dropping any optimization here.
There was a problem hiding this comment.
I collaborated with @CascadingRadium on this and we made sure to preserve any existing behaviour that was present before vectors and only remove the double processing for vector fields.
abhinavdangeti
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.