Merge remote-tracking branch 'origin/7.6.x-couchbase' #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-faiss: * 2127bb0 Likith B | MB-64513: Removing modification of max codes based on filtered document size
1. Changed weight of a kNN query to 1 to allow the boost value to kick in when computing query score. Since the weight of only the kNN scorer is changed, this will not impact how boosting is calculated for other types of queries. To reduce the kNN score relative to the FTS query score, set boost to <1. 2. Added a unit test which demonstrates boost increasing scores even for pure kNN queries(kNN + match none query).
Currently, filter eligible hits, which aren't specific to a segment, are computed redundantly for each segment. This PR pre-computes the eligible segment IDs and re-uses these for each segment.
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|
| * a20efc1 Aditi Ahuja | MB-64883 - Avoid redundant computation of eligible IDs (#2143)`