Reuse buffers while querying vector indexes #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CascadingRadium
commented
Feb 7, 2024
CascadingRadium
commented
- interface changes to support Reuse buffers while querying vector indexes bleve#1980
- i will close PR if interface change is not allowed
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
| @@ -266,14 +266,14 @@ func (vpl *VecPostingsIterator) BytesWritten() uint64 { | |||
|
|
|||
| // vectorIndexWrapper conforms to scorch_segment_api's VectorIndex interface | |||
| type vectorIndexWrapper struct { | |||
| search func(qVector []float32, k int64, except *roaring.Bitmap) (segment.VecPostingsList, error) | |||
| search func(qVector []float32, k int64, except *roaring.Bitmap, distanceBuffer []float32, labelBuffer []int64) (segment.VecPostingsList, error) | |||
There was a problem hiding this comment.
This is detail bleed across projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.