Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored toUseExplorerTheme and fix LCLCocoa "Range check error" in InitializeGlobalStructures #18

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

salvadorbs
Copy link

Hi,

in this request, I make two changes:

  • I restored toUseExplorerTheme's code (but only for Windows platform, using ifdef Windows). Imho, this option should be usable only in Windows context (maybe need other changes to make this option harmless on other os?), to resemble Explorer Theme and not in other OS, with a completely different theme. Also with toUseExplorerTheme activated, the option toHotTrack and plus/minus button were broken.
  • Make the changes done in issue LCLCocoa "Range check error" in InitializeGlobalStructures  #12. I haven't a Mac, so I can't test this, but since I was there, I tried make the fix requested.

I hope you will accept these changes. Thank you very much.

Bye.

@salvadorbs salvadorbs changed the title Lazarus v5 Restored toUseExplorerTheme and fix LCLCocoa "Range check error" in InitializeGlobalStructures Jul 7, 2020
@blikblum blikblum merged commit 38c2c75 into blikblum:lazarus-v5 Jul 7, 2020
@blikblum
Copy link
Owner

blikblum commented Jul 7, 2020

Thanks

@salvadorbs salvadorbs deleted the lazarus-v5 branch July 7, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants